Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: hiera/roles/fileserver.yaml
Issue
29551585
:
#2317 - provide role fileserver for eyeofiles.com (Closed)
Base URL: https://hg1/infrastructure
Patch Set: move into adblockplus::web namespace and other improvements
Created Sept. 21, 2017, 8:37 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: move into adblockplus::web namespace and other improvements
Patch Set 3: replace hardcoded repository with definition
Patch Set 4: make repository into subdomains
Patch Set 5: use single nginx conf based on $host
Patch Set 6: more flexible resource definitions
Right:
Patch Set 1: None
Patch Set 2: move into adblockplus::web namespace and other improvements
Patch Set 3: replace hardcoded repository with definition
Patch Set 4: make repository into subdomains
Patch Set 5: use single nginx conf based on $host
Patch Set 6: more flexible resource definitions
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
hiera/roles/fileserver.yaml
modules/adblockplus/files/nginx/fileserver.conf
modules/adblockplus/manifests/web/fileserver.pp
modules/private-stub/files/eyeofiles.com_sslcert.key
modules/private-stub/files/eyeofiles.com_sslcert.pem
modules/private-stub/hiera/hosts.yaml
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
modules/adblockplus/files/nginx/fileserver.conf »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
classes:
2
adblockplus::web::fileserver:
3
domain: eyeofiles.com
4
certificate: eyeofiles.com_sslcert.pem
5
private_key: eyeofiles.com_sslcert.key
6
is_default: true
7
OLD
NEW
« no previous file with comments
|
« no previous file
|
modules/adblockplus/files/nginx/fileserver.conf »
('j') |
no next file with comments »
Edit Message
Issue 29551585: #2317 - provide role fileserver for eyeofiles.com (Closed)
Created Sept. 21, 2017, 8:46 a.m. by f.nicolaisen
Modified Sept. 29, 2017, 10:31 a.m.
Reviewers: mahtias_adblockplus.org, f.lopez
Base URL: https://hg1/infrastructure
Comments: 48
This is Rietveld