modules/adblockplus/files/nginx/fileserver.conf - Issue 29551585: #2317 - provide role fileserver for eyeofiles.com

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: modules/adblockplus/files/nginx/fileserver.conf

Issue 29551585: #2317 - provide role fileserver for eyeofiles.com (Closed) Base URL: https://hg1/infrastructure

Patch Set: replace hardcoded repository with definition Created Sept. 21, 2017, 9:34 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 keepalive_timeout 0;

	2 root /var/www;

	3

	4 location /
	mathias 2017/09/22 07:00:14 Actually the idea was to use sub-domains (e.g. v8. Actually the idea was to use sub-domains (e.g. v8.eyeofiles.com), where each sub-domain would map to an element within a root directory (i.e. ${adblockplus::web::directory}/v8.eyeofiles.com -> ${adblockplus::directory}/fileserver/v8). f.nicolaisen 2017/09/22 07:57:43 Acknowledged. Assuming this is a must-have. If th Show quoted text On 2017/09/22 07:00:14, mathias wrote: > Actually the idea was to use sub-domains (e.g. http://v8.eyeofiles.com), where each > sub-domain would map to an element within a root directory (i.e. > ${adblockplus::web::directory}/v8.eyeofiles.com -> > ${adblockplus::directory}/fileserver/v8). Acknowledged. Assuming this is a must-have. If this is rather a nice-to-have that we can postpone for the sake of expediency, let me know.
	5 {

	6 }

	7

OLD	NEW