libadblockplus-android/src/org/adblockplus/libadblockplus/Platform.java - Issue 29556582: Issue 5643 - Make v8::Isolate injectable into JsEngine

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android/src/org/adblockplus/libadblockplus/Platform.java

Issue 29556582: Issue 5643 - Make v8::Isolate injectable into JsEngine (Closed)

Patch Set: reverted not related changes, addressed sergei's comments Created Sept. 26, 2017, 11:15 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« libadblockplus-android/jni/JniPlatform.cpp ('K') | « libadblockplus-android/jni/JniPlatform.cpp ('k') | libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android/src/org/adblockplus/libadblockplus/Platform.java

diff --git a/libadblockplus-android/src/org/adblockplus/libadblockplus/Platform.java b/libadblockplus-android/src/org/adblockplus/libadblockplus/Platform.java

index 727af68691a6432c26b8cf06e2fbe51646739448..61370bc3f22c76a0fed28b30638f70df1b7a6c68 100644

--- a/libadblockplus-android/src/org/adblockplus/libadblockplus/Platform.java

+++ b/libadblockplus-android/src/org/adblockplus/libadblockplus/Platform.java

@@ -45,9 +45,14 @@ public class Platform implements Disposable

this.disposer = new Disposer(this, new DisposeWrapper(ptr));

}

+ public void setUpJsEngine(final AppInfo appInfo, final long v8IsolatePtr)

+ {

+ setUpJsEngine(this.ptr, appInfo, v8IsolatePtr);

+ }

public void setUpJsEngine(final AppInfo appInfo)

{

- setUpJsEngine(this.ptr, appInfo);

+ setUpJsEngine(appInfo, 0L);

}

public JsEngine getJsEngine()

@@ -96,7 +101,7 @@ public class Platform implements Disposable

private final static native long ctor(LogSystem logSystem, WebRequest webRequest, String basePath);

- private final static native void setUpJsEngine(long ptr, AppInfo appInfo);

+ private final static native void setUpJsEngine(long ptr, AppInfo appInfo, long v8IsolatePtr);

private final static native long getJsEnginePtr(long ptr);