Issue 5800 - Add option to specify a list of V8 libraries

libadblockplus-android/build.gradle

 apply plugin: 'com.android.library'
 
 android {
   compileSdkVersion 16
   buildToolsVersion "25.0.0"
 
   defaultConfig {
     minSdkVersion 11
     targetSdkVersion 16
     versionCode 1
@@ skipping 12 matching lines @@
 
   sourceSets {
     main {
       manifest.srcFile 'AndroidManifest.xml'
       java.srcDirs = ['src']
       res.srcDirs = ['res']
       jni.srcDirs = ['jni']
     }
   }
 
-  def sharedV8LibFilesSet = []
   def sharedV8LibFiles = System.getenv('SHARED_V8_LIB_FILENAMES')
   if (sharedV8LibFiles != null) {
+    def sharedV8LibFilesSet = []
     def sharedV8LibFilesArray = sharedV8LibFiles.split(' ')
     sharedV8LibFilesArray.each { eachFileName ->
       sharedV8LibFilesSet.add("**/" + eachFileName)
       println "[Configuration] Excluding shared v8 library " + eachFileName + " from AAR"
     }
+
+    packagingOptions {
+      excludes = sharedV8LibFilesSet

[diegocarloslima, 2017/11/08 13:25:55]

I think we weren't in the same page in my last comment. What I actually meant is
that here we could have something like: excludes = getSharedV8LibFileSet(),
which would be a call for the method `def getSharedV8LibFileSet() {...}` that
would return the array sharedV8LibFilesSet (either with elements or empty)

[anton, 2017/11/08 13:28:25]

It's equal to what we had before last patch set. I don't see any reason to
introduce methods as it's used once.

+    }
   } else {
     println "[Configuration] No shared v8 libraries excluded from AAR"
   }
 
-  packagingOptions {
-    excludes = sharedV8LibFilesSet

[diegocarloslima, 2017/10/16 10:04:28]

I just think that instead of using the sharedV8LibFilesSet var here, we should
make it a call to a method (e.g. getSharedV8LibFilesSet), so we won't tie the
packagingOptions closure with the order of execution of the sharedV8LibFilesSet
block

-  }
 }