Issue 2824 - Only consider ads subscriptions in chooseFilterSubscription

lib/subscriptionInit.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 64 matching lines @@
     if (subscription instanceof SpecialSubscription &&
         subscription.filters.length > 0)
       return false;
   }
 
   return true;
 }
 
 /**
  * Finds the element for the default ad blocking filter subscription based
- * on the users locale.

[Sebastian Noack, 2017/10/03 10:01:27]

Typo: users => user's

[wspee, 2017/10/03 10:14:46]

Done.

+ * on the user's locale.
  *
  * @param {HTMLCollection} subscriptions
  * @return {Element}
  */
 function chooseFilterSubscription(subscriptions)
 {
   let selectedItem = null;
   let selectedPrefix = null;
   let matchCount = 0;
   for (let subscription of subscriptions)
@@ skipping 132 matching lines @@
  * Sets a callback that is called with an array of subscriptions to be added
  * during initialization. The callback must return an array of subscriptions
  * that will effectively be added.
  *
  * @param {function} callback
  */
 exports.setSubscriptionsCallback = callback =>
 {
   subscriptionsCallback = callback;
 };