Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: includes/layout/header.tmpl

Issue 29563558: Issue 5823 - Change header content based on page on help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Left Patch Set: Created Oct. 3, 2017, 8:06 a.m.
Right Patch Set: Rebase and place help center url first in search sites Created Oct. 10, 2017, 6:44 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | settings.ini » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 {% if product_id %} 1 {% if product_id %}
2 {% set product = products[product_id] %} 2 {% set product = products[product_id] %}
3 {% set search_label = "Search " + product.full_name + " Help" %} 3 {% set search_label = "Search " + product.full_name + " Help" %}
4 {% set search_site = product.url + "," + config.get("general", "siteurl") %} 4 {% set search_site = config.get("general", "siteurl") + "," + product.url %}
juliandoucette 2017/10/09 22:58:06 Does the order matter? If so, I think we should pr
ire 2017/10/10 18:44:47 Done.
ire 2017/10/10 18:44:47 I don't know, there doesn't seem to be any documen
5 {% else %} 5 {% else %}
6 {% set search_label = "Search for help..." %} 6 {% set search_label = "Search for help..." %}
7 {% set search_site = config.get("general", "siteurl") %} 7 {% set search_site = config.get("general", "siteurl") %}
8 {% endif %} 8 {% endif %}
9 9
10 <header id="site-header" class="navbar {{ 'site-header-minimal' if product_id is not defined }}"> 10 <header id="site-header" class="navbar {{ 'site-header-minimal' if product_id is not defined }}">
11 <div class="navbar-wrapper"> 11 <div class="navbar-wrapper">
12 <h1 id="site-title"> 12 <h1 id="site-title">
13 {{ "index" | linkify() }} 13 {{ "index" | linkify() }}
14 <img src="/img/png/eyeo-help.png" srcset="/img/svg/eyeo-help.svg 2x" alt ="{{ "eyeo Help" | translate("site-title", "Image alt text") }}"> 14 <img src="/img/png/eyeo-help.png" srcset="/img/svg/eyeo-help.svg 2x" alt ="{{ "eyeo Help" | translate("site-title", "Image alt text") }}">
(...skipping 17 matching lines...) Expand all
32 {% if product_id %} 32 {% if product_id %}
33 <nav id="product-website-link"> 33 <nav id="product-website-link">
34 <a href="{{ product.url }}"> 34 <a href="{{ product.url }}">
35 {{ product.full_name | translate(product_id+"-product-link", "Link lab el") }}<img src="/img/png/external-icon.png" srcset="/img/svg/external-icon.svg 2x" alt="{{ "External link icon" | translate("external-link-icon", "Image alt te xt") }}"> 35 {{ product.full_name | translate(product_id+"-product-link", "Link lab el") }}<img src="/img/png/external-icon.png" srcset="/img/svg/external-icon.svg 2x" alt="{{ "External link icon" | translate("external-link-icon", "Image alt te xt") }}">
36 </a> 36 </a>
37 </nav> 37 </nav>
38 {% endif %} 38 {% endif %}
39 </div> 39 </div>
40 </div> 40 </div>
41 </header> 41 </header>
LEFTRIGHT
« no previous file | settings.ini » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld