Issue 5587 - Use options module

ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 60 matching lines @@
       if (index >= 0)
       {
         this._keys.splice(index, 1);
         this._values.splice(index, 1);
       }
     }
   };
 
   window.ext.PageMap = PageMap;
 
-  window.ext.showOptions = function(callback)
-  {
-    if (!/\/(?:mobile-)?options\.html/.test(top.location.href))

[Manish Jethani, 2017/10/04 21:15:33]

In the new version I've removed the "mobile-" part since we're planning to use
options.html as the top page always.

[Thomas Greiner, 2017/10/05 11:58:16]

We're only using options.html as the top page inside the extension. For the test
environment this top page doesn't exist though which is why this check is
necessary.

[Manish Jethani, 2017/10/05 12:09:25]

Ah, I see.

Made the change.

[Thomas Greiner, 2017/10/05 12:25:54]

Thanks.

-      window.open("options.html", "_blank");
-
-    if (callback)
-      callback();
-  };
-
   window.ext.devtools = {
     onCreated: {
       addListener(listener)
       {
         window.addEventListener("message", (event) =>
         {
           if (event.data.type == "devtools")
             listener(new ext.Page(event.source));
         });
       }
     }
   };
 }());