Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Side by Side Diff: firstRun.html

Issue 29565721: No Issue - Implemented first run page Base URL: https://hg.adblockplus.org/adblockplusui/
Patch Set: Addressed latest round of feedback Created Jan. 30, 2018, 2:06 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | firstRun.js » ('j') | firstRun.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-present eyeo GmbH 4 - Copyright (C) 2006-present eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
11 - but WITHOUT ANY WARRANTY; without even the implied warranty of 11 - but WITHOUT ANY WARRANTY; without even the implied warranty of
12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 - GNU General Public License for more details. 13 - GNU General Public License for more details.
14 - 14 -
15 - You should have received a copy of the GNU General Public License 15 - You should have received a copy of the GNU General Public License
16 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 16 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
17 --> 17 -->
18 18
19 <html> 19 <html>
20 <head> 20 <head>
21 <title class="i18n_firstRun_title"></title> 21 <title class="i18n_firstRun_title"></title>
22 <meta charset="utf-8" /> 22 <meta charset="utf-8" />
23 <meta name="viewport" content="width=device-width, initial-scale=1" /> 23 <meta name="viewport" content="width=device-width, initial-scale=1" />
24 <link type="text/css" href="skin/common.css" rel="stylesheet" /> 24 <link type="text/css" href="skin/common.css" rel="stylesheet" />
25 <link type="text/css" href="skin/firstRun.css" rel="stylesheet"/> 25 <link type="text/css" href="skin/defaults.css" rel="stylesheet" />
26 <script type="text/javascript" src="polyfill.js"></script> 26 <link type="text/css" href="skin/firstRun.css" rel="stylesheet"/>
27 <script type="text/javascript" src="ext/common.js"></script> 27 <script type="text/javascript" src="polyfill.js"></script>
Thomas Greiner 2018/02/16 16:19:10 Detail: The "type" property is optional in HTML5 s
28 <script type="text/javascript" src="ext/content.js"></script> 28 <script type="text/javascript" src="ext/common.js"></script>
29 <script type="text/javascript" src="common.js"></script> 29 <script type="text/javascript" src="ext/content.js"></script>
30 <script type="text/javascript" src="i18n.js"></script> 30 <script type="text/javascript" src="common.js"></script>
31 <script type="text/javascript" src="firstRun.js"></script> 31 <script type="text/javascript" src="i18n.js"></script>
32 </head> 32 <script type="text/javascript" src="firstRun.js"></script>
33 <body> 33 </head>
34 34
35 <body>
36
37 <nav id="navbar">
38 <div class="navbar-container">
39 <a href="https://adblockplus.org/en/" hreflang="en" id="navbar-logo">
Thomas Greiner 2018/02/16 16:19:08 As done with the Updates page, don't hardcode any
Thomas Greiner 2018/02/16 16:19:09 Unlike on the website itself, we don't know whethe
Thomas Greiner 2018/02/16 16:19:10 All external links should be opened in a new tab.
40 <img src="skin/img/navbar-logo.svg">
Thomas Greiner 2018/02/16 16:19:08 I noticed that the PNG files are still included in
41 <span>Adblock <strong>Plus</strong></span>
42 </a>
43 <a href="#" id="navbar-menu-toggle">
44 <img src="skin/img/menu-toggle.svg">
45 </a>
46 <ul id="navbar-menu">
47 <li>
48 <a href="https://adblockplus.org/en/about" hreflang="en" class="i18n_f irstRun_aboutLink"></a>
49 </li>
35 50
36 <header> 51 <li>
37 <img id="logo"> 52 <a href="https://adblockplus.org/en/features" hreflang="en" class="i18 n_firstRun_featuresLink"></a>
38 <h1 id="title-main" class="i18n_firstRun_title"></h1> 53 </li>
54
55 <li>
56 <a href="https://adblockplus.org/en/bugs" hreflang="en" class="i18n_fi rstRun_reportAnIssueLink"></a>
57 </li>
58
59 <li>
60 <a href="https://adblockplus.org/en/contribute" hreflang="en" class="i 18n_firstRun_contributeLink"></a>
61 </li>
62 </ul>
63 </div>
64 </nav>
65
66 <main>
67 <header id="installation-status-header">
68 <img src="skin/icons/first-run/icon-checkmark-header.svg" alt="checkmark i con">
Thomas Greiner 2018/02/16 16:19:09 Detail: As mentioned in the Updates page review, w
69 <h1 class="i18n_firstRun_title"></h1>
70 <p class="i18n_firstRun_subtitle"></p>
39 </header> 71 </header>
40 72
41 <section id="filterlistsReinitializedWarning" class="i18n_firstRun_filterlis tsReinitializedWarning warning" hidden="true"></section> 73 <div id="content" class="container content">
Thomas Greiner 2018/02/16 16:19:09 There are now two elements on this page with the I
42 74
43 <div id="content"> 75 <div id="content" class="row ta-centre">
44 <section id="general"> 76
45 <div id="acceptable-ads-block" class="block"> 77 <section class="column one-third">
46 <h2 class="i18n_firstRun_acceptableAdsHeadline"></h2> 78 <header class="section-header">
47 <p id="acceptable-ads-explanation" class="i18n_firstRun_acceptableAdsE xplanation"></p> 79 <img src="skin/icons/first-run/icon-checkmark.svg" alt="checkmark ic on">
48 </div> 80 <h2 class="i18n_firstRun_columnOneTitle"></h2>
49 <div id="abb-promotion-block" class="block"> 81 </header>
50 <h2 class="i18n_firstRun_abbPromotionHeadline"></h2> 82 <p id="first-column-description" class="i18n_firstRun_controlDescripti on column-description"></p>
Thomas Greiner 2018/02/16 16:19:08 Detail: There are still element IDs which mention
51 <a href="https://adblockbrowser.org/?ref=frp"> 83 <a id="options-trigger" class="i18n_firstRun_configure-button button-p rimary" href="#"></a>
52 <div> 84 </section>
53 <img src="skin/abb-logo.png" alt="Adblock Browser logo" /> 85
54 </div> 86 <section class="column one-third">
55 <div> 87 <header class="section-header">
56 <div class="i18n_firstRun_abbButtonTitle title"></div> 88 <img src="skin/icons/first-run/icon-rocket.svg" alt="rocket icon">
57 <div class="i18n_firstRun_abbButtonSubtitle subtitle"></div> 89 <h2 class="i18n_firstRun_columnTwoTitle"></h2>
58 </div> 90 </header>
59 </a> 91 <p class="i18n_firstRun_browserAppDescription column-description"></p>
60 </div> 92 <div class="store-buttons">
61 </section> 93 <a href="" class="store-button applestore-button">
Thomas Greiner 2018/02/16 16:19:11 Please add the missing links to the mobile stores.
62 94 <img src="skin/icons/first-run/appstore-bg.svg" alt="apple store b utton">
Thomas Greiner 2018/02/16 16:19:10 Let's reuse the app store badge SVGs we added for
63
64 <section id="share">
65 <h2 id="share-headline" class="i18n_firstRun_share_headline"></h2>
66
67 <div class="block">
68 <a id="donate" class="i18n_firstRun_donate" target="_blank"></a>
69 <span id="donate-label" class="i18n_firstRun_donate_label"></span>
70 </div>
71
72 <div class="block">
73 <div id="share-general" class="share-buttons">
74 <a id="share-facebook" href="https://www.facebook.com/adblockplus" t arget="_blank" data-script="https://facebook.com/plugins/like.php?">
75 </a> 95 </a>
76 <a id="share-twitter" href="https://twitter.com/adblockplus" target= "_blank" data-script="https://platform.twitter.com/widgets/"> 96 <a href="" class="store-button googleplay-button">
77 </a> 97 <img src="skin/icons/first-run/googleplay-bg.svg" alt="google play store button">
78 <a id="share-gplus" href="https://www.google.com/+AdblockPlus" targe t="_blank" data-script="https://apis.google.com/se/0/_/+1/fastbutton?">
79 </a> 98 </a>
80 </div> 99 </div>
100 </section>
101
102 <section class="column one-third">
103 <header class="section-header">
104 <img src="skin/icons/first-run/icon-lock.svg" alt="padlock icon">
105 <h2 class="i18n_firstRun_columnThreeTitle"></h2>
106 </header>
107 <p id="third-column-description" class="i18n_firstRun_fairUseDescripti on column-description"></p>
108 </section>
109 </div>
110 </div>
111 </main>
112
113 <footer id="footer" class="content">
114 <div class="container">
115 <div class="row">
116 <nav class="column one-fourth">
117 <h5 class="i18n_firstRun_footerResourcesHeader"></h5>
118 <ul>
119 <li><a href="https://adblockplus.org/en/acceptable-ads" class="i18n_ firstRun_footerAcceptableAdsLink" hreflang="en"></a></li>
120 <li><a href="https://adblockplus.org/en/documentation" class="i18n_f irstRun_footerDocumentationLink" hreflang="en"></a></li>
121 <li><a href="https://adblockplus.org/en/deployments" class="i18n_fir stRun_footerForAdminsLink" hreflang="en"></a></li>
122 </ul>
123 </nav>
124 <nav class="column one-fourth">
125 <h5 class="i18n_firstRun_footerCommunityHeader"></h5>
126 <ul>
127 <li><a href="https://adblockplus.org/releases/" class="i18n_firstRun _footerAnnouncementsLink" hreflang="en"></a></li>
128 <li><a href="https://adblockplus.org/blog/" class="i18n_firstRun_foo terBlogLink" hreflang="en"></a></li>
129 <li><a href="https://adblockplus.org/forum/" class="i18n_firstRun_fo oterForumLink" hreflang="en"></a></li>
130 <li><a href="https://adblockplus.org/en/development-builds" class="i 18n_firstRun_footerDevelopmentBuildsLink" hreflang="en"></a></li>
131 </ul>
132 </nav>
133 <nav class="column one-fourth">
134 <h5 class="i18n_firstRun_footerDevelopmentHeader"></h5>
135 <ul>
136 <li><a href="https://adblockplus.org/en/source" class="i18n_firstRun _footerSourceCodeLink" hreflang="en"></a></li>
137 <li><a href="https://issues.adblockplus.org/report/13" class="i18n_f irstRun_footerRoadmapLink" hreflang="en"></a></li>
138 <li><a href="https://adblockplus.org/en/tools" class="i18n_firstRun_ footerToolsLink" hreflang="en"></a></li>
139 <li><a href="https://eyeo.com/jobs/" class="i18n_firstRun_footerJobs Link" hreflang="en"></a></li>
140 </ul>
141 </nav>
142 <nav id="social-list" class="column one-fourth">
143 <h5 class="i18n_firstRun_footerFollowUsHeader"></h5>
144 <ul>
145 <li>
146 <a href="https://twitter.com/AdblockPlus" target="_blank">
147 <img src="skin/img/footer-twitter-glyphicon.png" alt="Twitter">
148 </a>
149 </li>
150 <li>
151 <a href="https://www.youtube.com/user/AdblockPlusOfficial" target= "_blank">
152 <img src="skin/img/footer-youtube-glyphicon.png">
153 </a>
154 </li>
155 <li>
156 <a href="https://www.facebook.com/adblockplus" target="_blank">
157 <img src="skin/img/footer-facebook-glyphicon.png">
158 </a>
159 </li>
160 <li>
161 <a href="https://www.instagram.com/adblockplus/" target="_blank">
162 <img src="skin/img/footer-instagram-glyphicon.png">
163 </a>
164 </li>
165 </ul>
166 </nav>
167 </div>
168 <div id="footer-legal">
169 <p id="copyright-notice" class="i18n_firstRun_footerCopyright"></p>
170 <ul id="legal-list">
171 <li><a href="https://adblockplus.org/en/terms" class="i18n_firstRun_fo oterTermsOfUseLink" hreflang="en"></a></li>
172 <li><a href="https://adblockplus.org/en/privacy" class="i18n_firstRun_ footerPrivacyPolicyLink" hreflang="en"></a></li>
173 <li><a href="https://adblockplus.org/en/impressum" class="i18n_firstRu n_footerLegalNoticeLink" hreflang="en"></a></li>
174 </ul>
175 </div>
176 </div>
177 </footer>
178
179 </body>
81 180
82 <!-- Chinese social networks -->
83 <div id="share-chinese" class="share-buttons">
84 <a id="share-renren" href="http://www.renren.com/601651969" target=" _blank">
85 </a>
86 <a id="share-weibo" href="http://e.weibo.com/adblockplus/" target="_ blank">
87 </a>
88 </div>
89 <span class="i18n_firstRun_share"></span>
90 </div>
91 </section>
92
93 </div>
94
95 <footer>
96 <a id="contributors" class="i18n_firstRun_contributor_credits"></a>
97 </footer>
98 </body>
99 </html> 181 </html>
OLDNEW
« no previous file with comments | « no previous file | firstRun.js » ('j') | firstRun.js » ('J')

Powered by Google App Engine
This is Rietveld