firstRun.html - Issue 29565721: No Issue - Implemented first run page

Delta Between Two Patch Sets: firstRun.html

Issue 29565721: No Issue - Implemented first run page Base URL: https://hg.adblockplus.org/adblockplusui/

Left Patch Set: Addressed newest round of feedback Created Oct. 20, 2017, 2:43 p.m.

Right Patch Set: Addressed latest round of feedback Created Jan. 30, 2018, 2:06 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 - This file is part of Adblock Plus <https://adblockplus.org/>,	3 - This file is part of Adblock Plus <https://adblockplus.org/>,

4 - Copyright (C) 2006-present eyeo GmbH	4 - Copyright (C) 2006-present eyeo GmbH

5 -	5 -

6 - Adblock Plus is free software: you can redistribute it and/or modify	6 - Adblock Plus is free software: you can redistribute it and/or modify

7 - it under the terms of the GNU General Public License version 3 as	7 - it under the terms of the GNU General Public License version 3 as

8 - published by the Free Software Foundation.	8 - published by the Free Software Foundation.

9 -	9 -

10 - Adblock Plus is distributed in the hope that it will be useful,	10 - Adblock Plus is distributed in the hope that it will be useful,

11 - but WITHOUT ANY WARRANTY; without even the implied warranty of	11 - but WITHOUT ANY WARRANTY; without even the implied warranty of

12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

13 - GNU General Public License for more details.	13 - GNU General Public License for more details.

14 -	14 -

15 - You should have received a copy of the GNU General Public License	15 - You should have received a copy of the GNU General Public License

16 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.	16 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.

17 -->	17 -->

18	18

19 <html>	19 <html>

20 <head>	20 <head>

21 <title class="i18n_firstRun_title"></title>	21 <title class="i18n_firstRun_title"></title>

22 <meta charset="utf-8" />	22 <meta charset="utf-8" />

23 <meta name="viewport" content="width=device-width, initial-scale=1" />	23 <meta name="viewport" content="width=device-width, initial-scale=1" />

24 <link type="text/css" href="skin/common.css" rel="stylesheet" />	24 <link type="text/css" href="skin/common.css" rel="stylesheet" />

25 <link type="text/css" href="skin/defaults.css" rel="stylesheet" />	25 <link type="text/css" href="skin/defaults.css" rel="stylesheet" />

26 <link type="text/css" href="skin/firstRun.css" rel="stylesheet"/>	26 <link type="text/css" href="skin/firstRun.css" rel="stylesheet"/>

27 <script type="text/javascript" src="polyfill.js"></script>	27 <script type="text/javascript" src="polyfill.js"></script>
	Thomas Greiner 2018/02/16 16:19:10 Detail: The "type" property is optional in HTML5 s Detail: The "type" property is optional in HTML5 so, unlike Websites, we can drop them for UI pages.
28 <script type="text/javascript" src="ext/common.js"></script>	28 <script type="text/javascript" src="ext/common.js"></script>

29 <script type="text/javascript" src="ext/content.js"></script>	29 <script type="text/javascript" src="ext/content.js"></script>

30 <script type="text/javascript" src="common.js"></script>	30 <script type="text/javascript" src="common.js"></script>

31 <script type="text/javascript" src="i18n.js"></script>	31 <script type="text/javascript" src="i18n.js"></script>

32 <script type="text/javascript" src="firstRun.js"></script>	32 <script type="text/javascript" src="firstRun.js"></script>

33 </head>	33 </head>

34	34

35 <body>	35 <body>

	36

	37 <nav id="navbar">

	38 <div class="navbar-container">

	39 <a href="https://adblockplus.org/en/" hreflang="en" id="navbar-logo">
	Thomas Greiner 2018/02/16 16:19:08 As done with the Updates page, don't hardcode any As done with the Updates page, don't hardcode any links but instead use documentation links. Thomas Greiner 2018/02/16 16:19:09 Unlike on the website itself, we don't know whethe Unlike on the website itself, we don't know whether the web page we're linking to will be fully translated. Therefore let's remove the "hreflang" property from all links. Thomas Greiner 2018/02/16 16:19:10 All external links should be opened in a new tab. All external links should be opened in a new tab. On the website that means that links such as this one should open in the same tab but since we're not on adblockplus.org but in the browser's UI, those links are also considered as external.
	40 <img src="skin/img/navbar-logo.svg">
	Thomas Greiner 2018/02/16 16:19:08 I noticed that the PNG files are still included in I noticed that the PNG files are still included in this review so please remove them since we're not using them anyway.
	41 <span>Adblock <strong>Plus</strong></span>

	42 </a>

	43 <a href="#" id="navbar-menu-toggle">

	44 <img src="skin/img/menu-toggle.svg">

	45 </a>

	46 <ul id="navbar-menu">

	47 <li>

	48 <a href="https://adblockplus.org/en/about" hreflang="en" class="i18n_f irstRun_aboutLink"></a>

	49 </li>

	50

	51 <li>

	52 <a href="https://adblockplus.org/en/features" hreflang="en" class="i18 n_firstRun_featuresLink"></a>

	53 </li>

	54

	55 <li>

	56 <a href="https://adblockplus.org/en/bugs" hreflang="en" class="i18n_fi rstRun_reportAnIssueLink"></a>

	57 </li>

	58

	59 <li>

	60 <a href="https://adblockplus.org/en/contribute" hreflang="en" class="i 18n_firstRun_contributeLink"></a>

	61 </li>

	62 </ul>

	63 </div>

	64 </nav>

	65

	66 <main>

	67 <header id="installation-status-header">

	68 <img src="skin/icons/first-run/icon-checkmark-header.svg" alt="checkmark i con">
	Thomas Greiner 2018/02/16 16:19:09 Detail: As mentioned in the Updates page review, w Detail: As mentioned in the Updates page review, we don't need to annotate purely decorative images such as this one but also others on this page. Instead let's use `alt=""` so that screen readers can ignore them. See also https://www.w3.org/WAI/tutorials/images/decorative/
	69 <h1 class="i18n_firstRun_title"></h1>

	70 <p class="i18n_firstRun_subtitle"></p>

	71 </header>

36	72

37 <nav id="navbar">	73 <div id="content" class="container content">
	Thomas Greiner 2018/02/16 16:19:09 There are now two elements on this page with the I There are now two elements on this page with the ID "content" so please avoid doing that or otherwise we'll run into issues due to it leading to undefined behavior.
38 <div class="navbar-container">	74

39 <a href="https://adblockplus.org/en/" hreflang="en" id="navbar-logo">	75 <div id="content" class="row ta-centre">

40 <img src="skin/img/navbar-logo.png" srcset="skin/img/navbar-logo.svg 2 x">	76
Thomas Greiner 2017/10/23 13:17:42 What's the reason for including both PNG as well a What's the reason for including both PNG as well as SVG files for each icon? juliandoucette 2017/10/23 13:27:35 He copied and pasted the new abp.org header. It's Show quoted text On 2017/10/23 13:17:42, Thomas Greiner wrote: > What's the reason for including both PNG as well as SVG files for each icon? He copied and pasted the new abp.org header. It's unclear to me how much we want to deviate from the abp.org implementation. martin 2017/10/23 14:43:26 As far as I know SVGs are served on high-dpi displ Show quoted text On 2017/10/23 13:27:35, juliandoucette wrote: > On 2017/10/23 13:17:42, Thomas Greiner wrote: > > What's the reason for including both PNG as well as SVG files for each icon? > > He copied and pasted the new http://abp.org header. It's unclear to me how much we want > to deviate from the http://abp.org implementation. As far as I know SVGs are served on high-dpi displays, hence the reason for including them. As @juliandoucette pointed out I simply copy / pasted his implementation of the header. Thomas Greiner 2017/10/23 16:45:48 That's indeed a tricky question how much it makes Show quoted text On 2017/10/23 14:43:26, martin wrote: > On 2017/10/23 13:27:35, juliandoucette wrote: > > On 2017/10/23 13:17:42, Thomas Greiner wrote: > > > What's the reason for including both PNG as well as SVG files for each icon? > > > > He copied and pasted the new http://abp.org header. It's unclear to me how > much we want > > to deviate from the http://abp.org implementation. That's indeed a tricky question how much it makes sense to deviate from it. Given that those are two different environments with different requirements I'd say we shouldn't try to force it at this point - especially not in a rushed situation like this one - but rather introduce inconsistencies where necessary and document them somewhere so that we can work on solutions later on that work equally well for both UI and Websites. Show quoted text > As far as I know SVGs are served on high-dpi displays, hence the reason for > including them. As @juliandoucette pointed out I simply copy / pasted his > implementation of the header. I'm just wondering why we're not using those SVGs for low-dpi screens as well. Presumably, this may be due to lacking support in older browsers which we don't need to support in the extension.
41 <span>Adblock <strong>Plus</strong></span>	77 <section class="column one-third">
Thomas Greiner 2017/10/23 13:17:42 Please make sure that any text we show in the UI i Please make sure that any text we show in the UI is translatable. That also includes alt-attributes unless they're only there for decoration. juliandoucette 2017/10/23 13:27:34 Is it necessary to make text that we do not transl Show quoted text On 2017/10/23 13:17:42, Thomas Greiner wrote: > Please make sure that any text we show in the UI is translatable. That also > includes alt-attributes unless they're only there for decoration. Is it necessary to make text that we do not translate translatable in ABPUI? (We don't translate "Adblock Plus" AFAIK.) martin 2017/10/23 14:43:26 I intentionally didn't i18n this because it's more Show quoted text On 2017/10/23 13:27:34, juliandoucette wrote: > On 2017/10/23 13:17:42, Thomas Greiner wrote: > > Please make sure that any text we show in the UI is translatable. That also > > includes alt-attributes unless they're only there for decoration. > > Is it necessary to make text that we do not translate translatable in ABPUI? (We > don't translate "Adblock Plus" AFAIK.) I intentionally didn't i18n this because it's more or less a brand name / logo. Not sure whether we should be translating it. Thomas Greiner 2017/10/23 16:45:48 You're right. We're not translating "Adblock Plus" Show quoted text On 2017/10/23 14:43:26, martin wrote: > On 2017/10/23 13:27:34, juliandoucette wrote: > > On 2017/10/23 13:17:42, Thomas Greiner wrote: > > > Please make sure that any text we show in the UI is translatable. That also > > > includes alt-attributes unless they're only there for decoration. > > > > Is it necessary to make text that we do not translate translatable in ABPUI? > (We > > don't translate "Adblock Plus" AFAIK.) > > I intentionally didn't i18n this because it's more or less a brand name / logo. > Not sure whether we should be translating it. You're right. We're not translating "Adblock Plus" in the options page either so feel free to ignore this part of my comment. Note that we usually do include it in our translation files though.
42 </a>	78 <header class="section-header">

43 <a href="#" id="navbar-menu-toggle">	79 <img src="skin/icons/first-run/icon-checkmark.svg" alt="checkmark ic on">

44 <img src="skin/img/menu-toggle.png" srcset="skin/img/menu-toggle.svg 2 x">	80 <h2 class="i18n_firstRun_columnOneTitle"></h2>

45 </a>	81 </header>

46 <ul id="navbar-menu">	82 <p id="first-column-description" class="i18n_firstRun_controlDescripti on column-description"></p>
	Thomas Greiner 2018/02/16 16:19:08 Detail: There are still element IDs which mention Detail: There are still element IDs which mention the order of the column (i.e. "first-column-description" and "third-column-description"). Furthermore, there are still message IDs which mention the order of the column (i.e. "firstRun_columnOneTitle", "firstRun_columnTwoTitle" and "firstRun_columnThreeTitle"). See also https://codereview.adblockplus.org/29565721/diff/29584656/firstRun.html#newco...
47	83 <a id="options-trigger" class="i18n_firstRun_configure-button button-p rimary" href="#"></a>

	84 </section>

	85

	86 <section class="column one-third">

	87 <header class="section-header">

	88 <img src="skin/icons/first-run/icon-rocket.svg" alt="rocket icon">

	89 <h2 class="i18n_firstRun_columnTwoTitle"></h2>

	90 </header>

	91 <p class="i18n_firstRun_browserAppDescription column-description"></p>

	92 <div class="store-buttons">

	93 <a href="" class="store-button applestore-button">
	Thomas Greiner 2018/02/16 16:19:11 Please add the missing links to the mobile stores. Please add the missing links to the mobile stores.
	94 <img src="skin/icons/first-run/appstore-bg.svg" alt="apple store b utton">
	Thomas Greiner 2018/02/16 16:19:10 Let's reuse the app store badge SVGs we added for Let's reuse the app store badge SVGs we added for the Updates page to avoid unnecessary duplication.
	95 </a>

	96 <a href="" class="store-button googleplay-button">

	97 <img src="skin/icons/first-run/googleplay-bg.svg" alt="google play store button">

	98 </a>

	99 </div>

	100 </section>

	101

	102 <section class="column one-third">

	103 <header class="section-header">

	104 <img src="skin/icons/first-run/icon-lock.svg" alt="padlock icon">

	105 <h2 class="i18n_firstRun_columnThreeTitle"></h2>

	106 </header>

	107 <p id="third-column-description" class="i18n_firstRun_fairUseDescripti on column-description"></p>

	108 </section>

	109 </div>

	110 </div>

	111 </main>

	112

	113 <footer id="footer" class="content">

	114 <div class="container">

	115 <div class="row">

	116 <nav class="column one-fourth">

	117 <h5 class="i18n_firstRun_footerResourcesHeader"></h5>

	118 <ul>

	119 <li><a href="https://adblockplus.org/en/acceptable-ads" class="i18n_ firstRun_footerAcceptableAdsLink" hreflang="en"></a></li>

	120 <li><a href="https://adblockplus.org/en/documentation" class="i18n_f irstRun_footerDocumentationLink" hreflang="en"></a></li>

	121 <li><a href="https://adblockplus.org/en/deployments" class="i18n_fir stRun_footerForAdminsLink" hreflang="en"></a></li>

	122 </ul>

	123 </nav>

	124 <nav class="column one-fourth">

	125 <h5 class="i18n_firstRun_footerCommunityHeader"></h5>

	126 <ul>

	127 <li><a href="https://adblockplus.org/releases/" class="i18n_firstRun _footerAnnouncementsLink" hreflang="en"></a></li>

	128 <li><a href="https://adblockplus.org/blog/" class="i18n_firstRun_foo terBlogLink" hreflang="en"></a></li>

	129 <li><a href="https://adblockplus.org/forum/" class="i18n_firstRun_fo oterForumLink" hreflang="en"></a></li>

	130 <li><a href="https://adblockplus.org/en/development-builds" class="i 18n_firstRun_footerDevelopmentBuildsLink" hreflang="en"></a></li>

	131 </ul>

	132 </nav>

	133 <nav class="column one-fourth">

	134 <h5 class="i18n_firstRun_footerDevelopmentHeader"></h5>

	135 <ul>

	136 <li><a href="https://adblockplus.org/en/source" class="i18n_firstRun _footerSourceCodeLink" hreflang="en"></a></li>

	137 <li><a href="https://issues.adblockplus.org/report/13" class="i18n_f irstRun_footerRoadmapLink" hreflang="en"></a></li>

	138 <li><a href="https://adblockplus.org/en/tools" class="i18n_firstRun_ footerToolsLink" hreflang="en"></a></li>

	139 <li><a href="https://eyeo.com/jobs/" class="i18n_firstRun_footerJobs Link" hreflang="en"></a></li>

	140 </ul>

	141 </nav>

	142 <nav id="social-list" class="column one-fourth">

	143 <h5 class="i18n_firstRun_footerFollowUsHeader"></h5>

	144 <ul>

48 <li>	145 <li>

49 <a href="https://adblockplus.org/en/about" hreflang="en" class="i1 8n_firstRun_aboutLink"></a>	146 <a href="https://twitter.com/AdblockPlus" target="_blank">

	147 <img src="skin/img/footer-twitter-glyphicon.png" alt="Twitter">

	148 </a>

50 </li>	149 </li>

51

52 <li>	150 <li>

53 <a href="https://adblockplus.org/en/features" hreflang="en" class= "i18n_firstRun_featuresLink"></a>	151 <a href="https://www.youtube.com/user/AdblockPlusOfficial" target= "_blank">

	152 <img src="skin/img/footer-youtube-glyphicon.png">

	153 </a>

54 </li>	154 </li>

55

56 <li>	155 <li>

57 <a href="https://adblockplus.org/en/bugs" hreflang="en" class="i18 n_firstRun_reportAnIssueLink"></a>	156 <a href="https://www.facebook.com/adblockplus" target="_blank">

	157 <img src="skin/img/footer-facebook-glyphicon.png">

	158 </a>

58 </li>	159 </li>

59

60 <li>	160 <li>

61 <a href="https://adblockplus.org/en/contribute" hreflang="en" clas s="i18n_firstRun_contributeLink"></a>	161 <a href="https://www.instagram.com/adblockplus/" target="_blank">

	162 <img src="skin/img/footer-instagram-glyphicon.png">

	163 </a>

62 </li>	164 </li>

63	165 </ul>

64 <li id="navbar-locale-menubar">	166 </nav>

65 <a href="#" id="navbar-locale-selected">	167 </div>

66 English (US)	168 <div id="footer-legal">

67 </a>	169 <p id="copyright-notice" class="i18n_firstRun_footerCopyright"></p>

68 <ul id="navbar-locale-menu">	170 <ul id="legal-list">

69	171 <li><a href="https://adblockplus.org/en/terms" class="i18n_firstRun_fo oterTermsOfUseLink" hreflang="en"></a></li>

70 <li>	172 <li><a href="https://adblockplus.org/en/privacy" class="i18n_firstRun_ footerPrivacyPolicyLink" hreflang="en"></a></li>

71 <a href="https://adblockplus.org/ar/firefox" hreflang="ar">	173 <li><a href="https://adblockplus.org/en/impressum" class="i18n_firstRu n_footerLegalNoticeLink" hreflang="en"></a></li>
juliandoucette 2017/10/21 16:18:42 These hrefs are not correct. We want to translate These hrefs are not correct. We want to translate this page, not goto adblockplus.org. The last first run page didn't have a language selector. Perhaps @greiner can explain how this page is / can be translated? Thomas Greiner 2017/10/23 12:01:55 IIRC I brought this up in a UI meeting that it doe Show quoted text On 2017/10/21 16:18:42, juliandoucette wrote: > These hrefs are not correct. We want to translate this page, not goto > http://adblockplus.org. The last first run page didn't have a language selector. > Perhaps @greiner can explain how this page is / can be translated? IIRC I brought this up in a UI meeting that it doesn't make sense to have the language selector in the first-run page. Also I'd like to point out that we don't include any links in the extension directly but instead use documentation links (see spec) to ensure that links don't break. martin 2017/10/23 14:43:25 What I know for sure is that the spec I'm currentl Show quoted text On 2017/10/23 12:01:55, Thomas Greiner wrote: > On 2017/10/21 16:18:42, juliandoucette wrote: > > These hrefs are not correct. We want to translate this page, not goto > > http://adblockplus.org. The last first run page didn't have a language > selector. > > Perhaps @greiner can explain how this page is / can be translated? > > IIRC I brought this up in a UI meeting that it doesn't make sense to have the > language selector in the first-run page. > > Also I'd like to point out that we don't include any links in the extension > directly but instead use documentation links (see spec) to ensure that links > don't break. What I know for sure is that the spec I'm currently working off of, does indeed include a language selector. If we decide to not include it in this iteration we should probably ping Jeen so that she can update the spec? I'm not sure as to what the proper procedure should be. Thomas Greiner 2017/10/23 16:45:48 Yep, filing a spec issue should be sufficient. Show quoted text On 2017/10/23 14:43:25, martin wrote: > On 2017/10/23 12:01:55, Thomas Greiner wrote: > > On 2017/10/21 16:18:42, juliandoucette wrote: > > > These hrefs are not correct. We want to translate this page, not goto > > > http://adblockplus.org. The last first run page didn't have a language > > selector. > > > Perhaps @greiner can explain how this page is / can be translated? > > > > IIRC I brought this up in a UI meeting that it doesn't make sense to have the > > language selector in the first-run page. > > > > > Also I'd like to point out that we don't include any links in the extension > > directly but instead use documentation links (see spec) to ensure that links > > don't break. > > What I know for sure is that the spec I'm currently working off of, does indeed > include a language selector. If we decide to not include it in this iteration we > should probably ping Jeen so that she can update the spec? I'm not sure as to > what the proper procedure should be. Yep, filing a spec issue should be sufficient.
72 العربية (AR)

73 </a>

74 </li>

75

76 <li>

77 <a href="https://adblockplus.org/bg/firefox" hreflang="bg">

78 Български (BG)

79 </a>

80 </li>

81

82 <li>

83 <a href="https://adblockplus.org/de/firefox" hreflang="de">

84 Deutsch (DE)

85 </a>

86 </li>

87

88 <li>

89 <a href="https://adblockplus.org/en/firefox" hreflang="en">

90 English (US)

91 </a>

92 </li>

93

94 <li>

95 <a href="https://adblockplus.org/es/firefox" hreflang="es">

96 Español (España) (LA)

97 </a>

98 </li>

99

100 <li>

101 <a href="https://adblockplus.org/fr/firefox" hreflang="fr">

102 Français (FR)

103 </a>

104 </li>

105

106 <li>

107 <a href="https://adblockplus.org/he/firefox" hreflang="he">

108 עברית (IL)

109 </a>

110 </li>

111

112 <li>

113 <a href="https://adblockplus.org/hu/firefox" hreflang="hu">

114 Magyar (HU)

115 </a>

116 </li>

117

118 <li>

119 <a href="https://adblockplus.org/ko/firefox" hreflang="ko">

120 한국어 (KR)

121 </a>

122 </li>

123

124 <li>

125 <a href="https://adblockplus.org/lt/firefox" hreflang="lt">

126 Lietuvių (LT)

127 </a>

128 </li>

129

130 <li>

131 <a href="https://adblockplus.org/nl/firefox" hreflang="nl">

132 Nederlands (NL)

133 </a>

134 </li>

135

136 <li>

137 <a href="https://adblockplus.org/pt_BR/firefox" hreflang="pt_B R">

138 Português (Brasil) (BR)

139 </a>

140 </li>

141

142 <li>

143 <a href="https://adblockplus.org/ru/firefox" hreflang="ru">

144 Русский (RU)

145 </a>

146 </li>

147

148 <li>

149 <a href="https://adblockplus.org/sk/firefox" hreflang="sk">

150 Slovenčina (SK)

151 </a>

152 </li>

153

154 <li>

155 <a href="https://adblockplus.org/zh_CN/firefox" hreflang="zh_C N">

156 中文(简体) (CN)

157 </a>

158 </li>

159

160 <li>

161 <a href="https://adblockplus.org/zh_TW/firefox" hreflang="zh_T W">

162 中文(台灣) (TW)

163 </a>

164 </li>

165

166 </ul>

167 </li>

168 </ul>	174 </ul>

169 </div>	175 </div>

170 </nav>	176 </div>

171	177 </footer>

172 <main>

173 <header id="installation-status-header">

174 <img src="skin/icons/first-run/icon-checkmark-header.svg" alt="checkma rk icon">

175 <h1 class="i18n_firstRun_title"></h1>

176 <p class="i18n_firstRun_subtitle"></p>

177 </header>

178	178

179 <div class="container content">	179 </body>

180

181 <div id="content-columns-container" class="row">

182

183 <section class="column one-third ta-centre">

184 <header class="section-header">

185 <img src="skin/icons/first-run/icon-checkmark.svg" alt="checkmark icon">

186 <h2 class="i18n_firstRun_columnOneTitle"></h2>

187 </header>

188 <p id="first-column-description" class="i18n_firstRun_columnOneDescr iption column-description"></p>
Thomas Greiner 2017/10/23 13:17:41 Detail: The order of the columns may change. Gener Detail: The order of the columns may change. Generally, we don't include styling or layouting information in such IDs but describe the purpose of the text. Otherwise we may end up having to translate the same text again simply because of changes to its ID. martin 2017/10/23 14:43:26 Completely agree. Will fix that. Show quoted text On 2017/10/23 13:17:41, Thomas Greiner wrote: > Detail: The order of the columns may change. Generally, we don't include styling > or layouting information in such IDs but describe the purpose of the text. > Otherwise we may end up having to translate the same text again simply because > of changes to its ID. Completely agree. Will fix that.
189 <a id="options-trigger" class="i18n_firstRun_configure-button button -primary" href="#"></a>

190 </section>

191

192 <section class="column one-third ta-centre">

193 <header class="section-header">

194 <img src="skin/icons/first-run/icon-rocket.svg" alt="rocket icon ">

195 <h2 class="i18n_firstRun_columnTwoTitle"></h2>

196 </header>

197 <p class="i18n_firstRun_columnTwoDescription column-description">< /p>

198 <div class="store-buttons">

199 <a href="" class="store-button applestore-button">
Thomas Greiner 2017/10/23 13:17:42 Don't we have the links for those buttons yet? Don't we have the links for those buttons yet? martin 2017/10/23 14:43:26 We probably do, however they are not included in t Show quoted text On 2017/10/23 13:17:42, Thomas Greiner wrote: > Don't we have the links for those buttons yet? We probably do, however they are not included in the spec. Will try and clarify that with Jeen. Thomas Greiner 2017/10/23 16:45:48 Great, thanks. Show quoted text On 2017/10/23 14:43:26, martin wrote: > On 2017/10/23 13:17:42, Thomas Greiner wrote: > > Don't we have the links for those buttons yet? > > We probably do, however they are not included in the spec. Will try and clarify > that with Jeen. Great, thanks.
200 <img src="skin/icons/first-run/appstore-bg.svg" alt="apple sto re button">

201 </a>

202 <a href="" class="store-button googleplay-button">

203 <img src="skin/icons/first-run/googleplay-bg.svg" alt="google play store button">

204 </a>

205 </div>

206 </section>

207

208 <section class="column one-third ta-centre">

209 <header class="section-header">

210 <img src="skin/icons/first-run/icon-lock.svg" alt="padlock icon" >

211 <h2 class="i18n_firstRun_columnThreeTitle"></h2>

212 </header>

213 <p id="third-column-description" class="i18n_firstRun_columnThreeD escription column-description"></p>

214 </section>

215

216 </div>

217

218 </div>

219 </main>

220

221 <footer id="footer" class="content">

222 <div class="container">

223 <div class="row">

224 <nav class="column one-fourth">

225 <h5 class="i18n_firstRun_footerResourcesHeader"></h5>

226 <ul>

227

228 <li><a href="https://adblockplus.org/en/acceptable-ads" class="i 18n_firstRun_footerAcceptableAdsLink" hreflang="en"></a></li>

229

230 <li><a href="https://adblockplus.org/en/documentation" class="i1 8n_firstRun_footerDocumentationLink" hreflang="en"></a></li>

231

232 <li><a href="https://adblockplus.org/en/deployments" class="i18n _firstRun_footerForAdminsLink" hreflang="en"></a></li>

233

234 </ul>

235 </nav>

236 <nav class="column one-fourth">

237 <h5class="i18n_firstRun_footerCommunityHeader"></h5>
juliandoucette 2017/10/21 16:18:42 Missing space. Missing space. martin 2017/10/23 14:43:27 Will fix. Show quoted text On 2017/10/21 16:18:42, juliandoucette wrote: > Missing space. Will fix.
238 <ul>

239 <li><a href="https://adblockplus.org/releases/" class="i18n_firstR un_footerAnnouncementsLink" hreflang="en"></a></li>

240 <li><a href="https://adblockplus.org/blog/" class="i18n_firstRun_f ooterBlogLink" hreflang="en"></a></li>

241 <li><a href="https://adblockplus.org/forum/" class="i18n_firstRun_ footerForumLink" hreflang="en"></a></li>

242

243

244 <li><a href="https://adblockplus.org/en/development-builds" class="i18n_ firstRun_footerDevelopmentBuildsLink" hreflang="en"></a></li>
Thomas Greiner 2017/10/23 13:17:42 Detail: Wrong indentation level and inconsisent sp Detail: Wrong indentation level and inconsisent spacing before and after. Same applies to other `<li>` elements in this file. martin 2017/10/23 14:43:25 Will fix. Sorry about that. Show quoted text On 2017/10/23 13:17:42, Thomas Greiner wrote: > Detail: Wrong indentation level and inconsisent spacing before and after. Same > applies to other `<li>` elements in this file. Will fix. Sorry about that.
245

246

247 </ul>

248 </nav>

249 <nav class="column one-fourth">

250 <h5 class="i18n_firstRun_footerDevelopmentHeader"></h5>

251 <ul>

252

253

254 <li><a href="https://adblockplus.org/en/source" class="i18n_firstRun_foo terSourceCodeLink" hreflang="en"></a></li>

255

256

257 <li><a href="https://issues.adblockplus.org/report/13" class="i18n _firstRun_footerRoadmapLink" hreflang="en"></a></li>

258

259

260 <li><a href="https://adblockplus.org/en/tools" class="i18n_firstRun_foot erToolsLink" hreflang="en"></a></li>

261

262

263 <li><a href="https://eyeo.com/jobs/" class="i18n_firstRun_footerJo bsLink" hreflang="en"></a></li>

264 </ul>

265 </nav>

266 <nav id="social-list" class="column one-fourth">

267 <h5 class="i18n_firstRun_footerFollowUsHeader"></h5>

268 <ul>

269 <li>

270 <a href="https://twitter.com/AdblockPlus" target="_blank">

271 <img src="skin/img/footer-twitter-glyphicon.png" alt="Twitter" >
Thomas Greiner 2017/10/23 13:17:41 I assume that those icons are were not created by I assume that those icons are were not created by us. If that's the case, are there any license terms we have to consider when distributing them publicly as well as including them in an open source product? juliandoucette 2017/10/23 13:27:34 Good question. I'll have to forward it along to pr Show quoted text On 2017/10/23 13:17:41, Thomas Greiner wrote: > I assume that those icons are were not created by us. If that's the case, are > there any license terms we have to consider when distributing them publicly as > well as including them in an open source product? Good question. I'll have to forward it along to product. I didn't ask :/
272 </a>

273 </li>

274 <li>

275 <a href="https://www.youtube.com/user/AdblockPlusOfficial" targe t="_blank">

276 <img src="skin/img/footer-youtube-glyphicon.png">

277 </a>

278 </li>

279 <li>

280 <a href="https://www.facebook.com/adblockplus" target="_blank">

281 <img src="skin/img/footer-facebook-glyphicon.png">

282 </a>

283 </li>

284 <li>

285 <a href="https://www.instagram.com/adblockplus/" target="_blank" >

286 <img src="skin/img/footer-instagram-glyphicon.png">

287 </a>

288 </li>

289 </ul>

290 </nav>

291 </div>

292 <div id="footer-legal">

293 <p id="copyright-notice" class="i18n_firstRun_footerCopyright"></p>

294 <ul id="legal-list">

295

296 <li><a href="https://adblockplus.org/en/terms" class="i18n_firstRu n_footerTermsOfUseLink" hreflang="en"></a></li>

297

298 <li><a href="https://adblockplus.org/en/privacy" class="i18n_first Run_footerPrivacyPolicyLink" hreflang="en"></a></li>

299

300 <li><a href="https://adblockplus.org/en/impressum" class="i18n_fir stRun_footerLegalNoticeLink" hreflang="en"></a></li>

301

302 </ul>

303 </div>

304 </div>

305 </footer>

306

307 </body>

308	180

309 </html>	181 </html>

LEFT	RIGHT