Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: firstRun.js

Issue 29565721: No Issue - Implemented first run page Base URL: https://hg.adblockplus.org/adblockplusui/
Patch Set: Created Oct. 5, 2017, 1:47 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: firstRun.js
===================================================================
--- a/firstRun.js
+++ b/firstRun.js
@@ -18,103 +18,28 @@
/* globals checkShareResource, getDocLink, openSharePopup, setLinks, E */
"use strict";
(function()
{
function onDOMLoaded()
{
- // Set up logo image
- let logo = E("logo");
- logo.src = "skin/abp-128.png";
- let errorCallback = function()
- {
- logo.removeEventListener("error", errorCallback, false);
- // We are probably in Chrome/Opera/Safari, the image has a different path.
- logo.src = "icons/detailed/abp-128.png";
- };
- logo.addEventListener("error", errorCallback, false);
-
- // Set up URLs
- getDocLink("donate", (link) =>
- {
- E("donate").href = link;
- });
- getDocLink("contributors", (link) =>
- {
- E("contributors").href = link;
- });
-
- getDocLink("acceptable_ads_criteria", (link) =>
- {
- setLinks("acceptable-ads-explanation", link, openFilters);
- });
+ const optionsTrigger = E("options-trigger");
- getDocLink("contribute", (link) =>
- {
- setLinks("share-headline", link);
- });
-
- ext.backgroundPage.sendMessage({
- type: "app.get",
- what: "issues"
- }, (issues) =>
+ optionsTrigger.addEventListener("click", (e) =>
{
- // Show warning if filterlists settings were reinitialized
- if (issues.filterlistsReinitialized)
- {
- E("filterlistsReinitializedWarning").removeAttribute("hidden");
- setLinks("filterlistsReinitializedWarning", openFilters);
- }
- });
-
- updateSocialLinks();
-
- ext.onMessage.addListener((message) =>
- {
- if (message.type == "subscriptions.respond")
- {
- updateSocialLinks();
- }
- });
- ext.backgroundPage.sendMessage({
- type: "subscriptions.listen",
- filter: ["added", "removed", "updated", "disabled"]
- });
- }
+ e.preventDefault();
+ openFilters();
+ })
- function updateSocialLinks()
- {
- for (let network of ["twitter", "facebook", "gplus"])
- {
- let link = E("share-" + network);
- checkShareResource(link.getAttribute("data-script"), (isBlocked) =>
- {
- // Don't open the share page if the sharing script would be blocked
- if (isBlocked)
- link.removeEventListener("click", onSocialLinkClick, false);
- else
- link.addEventListener("click", onSocialLinkClick, false);
- });
- }
- }
+ setLinks("first-column-description", " https://adblockplus.org/terms");
+ setLinks("third-column-description", "https://adblockplus.org/acceptable-ads#optout");
- function onSocialLinkClick(event)
- {
- if (window.matchMedia("(max-width: 970px)").matches)
- return;
-
- event.preventDefault();
-
- getDocLink(event.target.id, (link) =>
- {
- openSharePopup(link);
- });
}
function openFilters()
{
ext.backgroundPage.sendMessage({type: "app.open", what: "options"});
}
document.addEventListener("DOMContentLoaded", onDOMLoaded, false);

Powered by Google App Engine
This is Rietveld