Issue 5593 - Use messaging for the popup's notification code

notification.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-/* global togglePref */
+/* global setPref */
 
 "use strict";
 
 function getDocLinks(notification)
 {
-  let docLinks = [];
-
   if (!notification.links)
-    return Promise.resolve(docLinks);
+    return Promise.resolve([]);
 
   return Promise.all(
     notification.links.map(link =>
     {
       return new Promise((resolve, reject) =>
       {
         chrome.runtime.sendMessage({
           type: "app.get",
           what: "doclink",
           link
@@ skipping 13 matching lines @@
   }
 
   let before = match[1];
   let tagName = match[2];
   let value = match[3];
   let after = match[4];
 
   insertMessage(element, before, links);
 
   let newElement = document.createElement(tagName);
-  if (tagName === "a" && links && links.length)
+  if (tagName == "a" && links && links.length)
     newElement.href = links.shift();
   insertMessage(newElement, value, links);
   element.appendChild(newElement);
 
   insertMessage(element, after, links);
 }
 
 window.addEventListener("load", () =>
 {
   chrome.runtime.sendMessage({
     type: "notifications.get",
     displayMethod: "popup"
   }, notification =>
   {
     if (!notification)
       return;
 
     let titleElement = document.getElementById("notification-title");
     let messageElement = document.getElementById("notification-message");
 
     titleElement.textContent = notification.texts.title;
 
     getDocLinks(notification).then(docLinks =>
     {
       insertMessage(messageElement, notification.texts.message, docLinks);
 
       messageElement.addEventListener("click", event =>
       {
         let link = event.target;
-        while (link && link !== messageElement && link.localName !== "a")

[Sebastian Noack, 2017/10/08 01:19:21]

Nit: As per the Mozilla coding style guide, which is referenced in our coding
style  guide, we prefer == and != over of === and !==.

[kzar, 2017/10/08 10:13:45]

Done.

+        while (link && link != messageElement && link.localName != "a")
           link = link.parentNode;
         if (!link)
           return;
         event.preventDefault();
         event.stopPropagation();
-        ext.pages.open(link.href);
+        chrome.tabs.create({url: link.href});
       });
     });
 
     let notificationElement = document.getElementById("notification");
     notificationElement.className = notification.type;
     notificationElement.hidden = false;
     notificationElement.addEventListener("click", event =>
     {
       if (event.target.id == "notification-close")
         notificationElement.classList.add("closing");
       else if (event.target.id == "notification-optout" ||
                event.target.id == "notification-hide")
       {
         if (event.target.id == "notification-optout")
-          togglePref("notifications_ignoredcategories");
+          setPref("notifications_ignoredcategories", true);
 
         notificationElement.hidden = true;
         notification.onClicked();
       }
     }, true);
   });
 }, false);