notification.js - Issue 29567749: Issue 5593 - Use messaging for the popup's notification code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: notification.js

Issue 29567749: Issue 5593 - Use messaging for the popup's notification code (Closed)

Left Patch Set: Use chrome.tabs.create Created Oct. 9, 2017, 3:46 p.m.

Right Patch Set: Rebased Created Oct. 9, 2017, 4:47 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-present eyeo GmbH	3 * Copyright (C) 2006-present eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 97 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
108 {	108 {

109 if (event.target.id == "notification-optout")	109 if (event.target.id == "notification-optout")

110 setPref("notifications_ignoredcategories", true);	110 setPref("notifications_ignoredcategories", true);

111	111

112 notificationElement.hidden = true;	112 notificationElement.hidden = true;

113 notification.onClicked();	113 notification.onClicked();

114 }	114 }

115 }, true);	115 }, true);

116 });	116 });

117 }, false);	117 }, false);

LEFT	RIGHT