Noissue - Added flake8-docstrings (sitescripts)

sitescripts/extensions/bin/createNightlies.py

 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-present eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 114 matching lines @@
         for change in result.split('\x00\x00'):
             if change:
                 date, author, revision, description = change.split('\x00')
                 yield {'date': date, 'author': author, 'revision': revision, 'description': description}
 
     def copyRepository(self):
         """
           Create a repository copy in a temporary directory
         """
         self.tempdir = tempfile.mkdtemp(prefix=self.config.repositoryName)
-        command = ['hg', 'clone', '-q', self.config.repository,  '-u',
+        command = ['hg', 'clone', '-q', self.config.repository, '-u',

[Sebastian Noack, 2017/10/09 01:56:17]

For some reason flake8 didn't detect this redundant space before installing
flake8-docstrings, even though it isn't a D* error.

[Vasily Kuznetsov, 2017/10/09 20:39:47]

This is really strange... how are we supposed to trust it after this :/

[Sebastian Noack, 2017/10/10 22:01:48]

I figured out what is going on here. This wasn't related to installing
flake8-docstrings. Everything works as intended. By default flake8 (and
pycodingstyles) ignore E24 (along some other errors, i.e. E121, E123, E126,
E226, E704, W503 and W504). That is because PEP-8 doesn't explicitly
mention/discourage these practices. However, I went through the list, and every
single of these errors is something that you and I would complain about, if
noticed in a code reviews. So it is good that these are no longer ignored.

The reason why they are no longer ignored is that we added `ignore = D1` to the
flake8 section in tox.ini, overriding any pre-defined ignores. If we wouldn't
have at least one global ignore in each project (i.e. D1), now, I would suggest
to add `ignore =` to each project that doesn't have anything to ignore, in order
to get the above errors.

                    self.config.revision, self.tempdir]
         subprocess.check_call(command)
 
         # Make sure to run ensure_dependencies.py if present
         depscript = os.path.join(self.tempdir, 'ensure_dependencies.py')
         if os.path.isfile(depscript):
             subprocess.check_call([sys.executable, depscript, '-q'])
 
     def writeChangelog(self, changes):
         """
@@ skipping 587 matching lines @@
         except Exception as ex:
             logging.error('The build for %s failed:', repo)
             logging.exception(ex)
 
     file = open(nightlyConfigFile, 'wb')
     nightlyConfig.write(file)
 
 
 if __name__ == '__main__':
     main()