Issue 5587- Use dedicated mobile options page in Firefox Mobile

options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
+// In Edge the namespace for extension APIs is 'browser'. The 'chrome' object,
+// while available does not contain the runtime object needed below.
+if (typeof chrome == "undefined" || typeof chrome.runtime == "undefined")
+  window.chrome = window.browser;

[Sebastian Noack, 2017/10/09 15:29:27]

This fallback is duplicated in ext/common.js. However, since we don't want to
increase the usage of ext, but eventually get rid of it, I suggest to move the
code from ext/common.js that isn't specific to ext, into a separate script and
is included everywhere where ext/common.js is used and in options.js. An
appropriate name for such a script would be polyfill.js, and its content should
look like this:

  // In Edge the namespace for extension APIs is 'browser'. The 'chrome' object,
  // while available does not contain the runtime object needed below.
  if (typeof chrome == "undefined" || typeof chrome.extension == "undefined")
    window.chrome = window.browser;

  // Workaround since HTMLCollection, NodeList, StyleSheet and
  // CSSRuleList didn't have iterator support before Chrome 51.
  // https://bugs.chromium.org/p/chromium/issues/detail?id=401699
  let arrayIterator = Array.prototype[Symbol.iterator];
  if (!(Symbol.iterator in HTMLCollection.prototype))
    HTMLCollection.prototype[Symbol.iterator] = arrayIterator;
  if (!(Symbol.iterator in NodeList.prototype))
    NodeList.prototype[Symbol.iterator] = arrayIterator;
  if (!(Symbol.iterator in StyleSheetList.prototype))
    StyleSheetList.prototype[Symbol.iterator] = arrayIterator;
  if (!(Symbol.iterator in CSSRuleList.prototype))
    CSSRuleList.prototype[Symbol.iterator] = arrayIterator;

+
 let iframe = document.getElementById("content");
 
 iframe.onload = () =>
 {
   document.title = iframe.contentDocument.title;
 };
-
-// In Edge the namespace for extension APIs is 'browser'. The 'chrome' object,
-// while available does not contain the runtime object needed below.
-if (typeof chrome == "undefined" || typeof chrome.runtime == "undefined")

[Manish Jethani, 2017/10/09 12:03:52]

LGTM

I would move it to the top of the file though, right after "use strict", but
your call.

-  window.chrome = window.browser;
 
 chrome.runtime.sendMessage({
   type: "app.get",
   what: "application"
 },
 application =>
 {
   // Load the mobile version of the options page on Firefox for Android.
   iframe.src = iframe.getAttribute("data-src-" + application) ||
                iframe.getAttribute("data-src");
 });