Issue 5847 - Add prefs.set message handler

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 317 matching lines @@
       {
         listenedPreferences[preference] = null;
         Prefs.on(preference, () =>
         {
           sendMessage("pref", preference, Prefs[preference]);
         });
       }
     }
   });
 
+  port.on("prefs.set", (message, sender) =>
+  {
+    if (message.key == "notifications_ignoredcategories")
+      return NotificationStorage.toggleIgnoreCategory("*", !!message.value);
+
+    return Prefs[message.key] = message.value;
+  });
+
   port.on("prefs.toggle", (message, sender) =>
   {
     if (message.key == "notifications_ignoredcategories")
-      return NotificationStorage.toggleIgnoreCategory("*", message.forceValue);
-
-    if (typeof message.forceValue == "undefined")

[Manish Jethani, 2017/10/09 14:41:45]

I really think there should be a separate "prefs.set" for this, and even
"notifications_ignoredcategories" could be covered by it, since passing
forceValue there is the equivalent of setting the preference.

[kzar, 2017/10/09 14:45:09]

Yea you're probably right. I'll update the issue.

-      return Prefs[message.key] = !Prefs[message.key];
-    else
-      return Prefs[message.key] = message.forceValue;
+      return NotificationStorage.toggleIgnoreCategory("*");
+
+    return Prefs[message.key] = !Prefs[message.key];
   });
 
   port.on("notifications.get", (message, sender) =>
   {
     let notification = getActiveNotification();
 
     if (!notification ||
         "displayMethod" in message &&
         !shouldDisplay(message.displayMethod, notification.type))
       return;
@@ skipping 75 matching lines @@
     if (message.url)
       subscriptions = [Subscription.fromURL(message.url)];
 
     for (let subscription of subscriptions)
     {
       if (subscription instanceof DownloadableSubscription)
         Synchronizer.execute(subscription, true);
     }
   });
 })(this);