Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: messageResponder.js

Issue 29570584: Issue 5847 - Add prefs.set message handler (Closed)
Patch Set: Honour forceValue for other preferences while at it Created Oct. 9, 2017, 2:36 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: messageResponder.js
diff --git a/messageResponder.js b/messageResponder.js
index 47f4b05a9d88c8969531c2aac61c2d9ea0270cc0..62a309f7a1cbf4cf0f23abfd37852d95adcdac2d 100644
--- a/messageResponder.js
+++ b/messageResponder.js
@@ -338,9 +338,12 @@
port.on("prefs.toggle", (message, sender) =>
{
if (message.key == "notifications_ignoredcategories")
- return NotificationStorage.toggleIgnoreCategory("*");
+ return NotificationStorage.toggleIgnoreCategory("*", message.forceValue);
- return Prefs[message.key] = !Prefs[message.key];
+ if (typeof message.forceValue == "undefined")
Manish Jethani 2017/10/09 14:41:45 I really think there should be a separate "prefs.s
kzar 2017/10/09 14:45:09 Yea you're probably right. I'll update the issue.
+ return Prefs[message.key] = !Prefs[message.key];
+ else
+ return Prefs[message.key] = message.forceValue;
});
port.on("notifications.get", (message, sender) =>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld