lib/uninstall.js - Issue 29570614: Issue 5028 - Use browser namespace

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: lib/uninstall.js

Issue 29570614: Issue 5028 - Use browser namespace (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Left Patch Set: Created Oct. 9, 2017, 3:12 p.m.

Right Patch Set: Update adblockplusui dependency Created Oct. 17, 2017, 1:02 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-present eyeo GmbH	3 * Copyright (C) 2006-present eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
42 downlCount = "30-89";	42 downlCount = "30-89";

43 else if (downlCount < 180)	43 else if (downlCount < 180)

44 downlCount = "90-179";	44 downlCount = "90-179";

45 else	45 else

46 downlCount = "180+";	46 downlCount = "180+";

47 }	47 }

48	48

49 search.push("notificationDownloadCount=" + encodeURIComponent(downlCount));	49 search.push("notificationDownloadCount=" + encodeURIComponent(downlCount));

50	50

51 browser.runtime.setUninstallURL(Utils.getDocLink("uninstalled") + "&" +	51 browser.runtime.setUninstallURL(Utils.getDocLink("uninstalled") + "&" +

52 search.join("&"));	52 search.join("&"));

53 }	53 }

54	54

55 // The uninstall URL contains the notification download count as a parameter,	55 // The uninstall URL contains the notification download count as a parameter,

56 // therefore we must wait for preferences to be loaded before generating the	56 // therefore we must wait for preferences to be loaded before generating the

57 // URL and we need to re-generate it each time the notification data changes.	57 // URL and we need to re-generate it each time the notification data changes.

58 if ("setUninstallURL" in browser.runtime)	58 if ("setUninstallURL" in browser.runtime)

59 {	59 {

60 Prefs.untilLoaded.then(setUninstallURL);	60 Prefs.untilLoaded.then(setUninstallURL);

61 Prefs.on("notificationdata", setUninstallURL);	61 Prefs.on("notificationdata", setUninstallURL);

62 }	62 }

LEFT	RIGHT