Noissue - Lint adjustments

mobile/android/thirdparty/org/adblockplus/browser/StartPane.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 33 matching lines @@
 import android.view.ViewGroup.LayoutParams;
 import android.view.Window;
 import android.widget.Button;
 import android.widget.LinearLayout;
 import android.widget.TextView;
 
 public class StartPane extends DialogFragment implements OnClickListener, OnKeyListener
 {
   private static final String TAG = "AdblockBrowser.StartPane";
   private int currentStep = 0;
-  private static final HashMap<String, Integer> FONTS = new HashMap<String, Integer>();
-  private HashMap<String, Typeface> loadedFonts = new HashMap<String, Typeface>();
+  private static final HashMap<String, Integer> FONTS = new HashMap<>();
+  private final HashMap<String, Typeface> loadedFonts = new HashMap<>();
 
   private static final int[] BETA_RESOURCE_LIST =
   {
     R.layout.abb_start_pane_step_1, R.string.abb_frp_button_1,
     R.layout.abb_start_pane_step_2, R.string.abb_frp_button_2,
     R.layout.abb_start_pane_step_3, R.string.abb_frp_button_3
   };
 
   private static final int[] RELEASE_RESOURCE_LIST =
   {
     R.layout.abb_start_pane_step_1, R.string.abb_frp_button_2,
     R.layout.abb_start_pane_step_2, R.string.abb_frp_button_3
   };
 
   private int[] pagesResourceList;
 
   static
   {
     FONTS.put("ttf_opensans_light", R.raw.opensans_light);
     FONTS.put("ttf_opensans_semibold", R.raw.opensans_semibold);
   }
 
-  static Typeface typefaceFromResource(final Context context, final int resId)
+  private static Typeface typefaceFromResource(final Context context, final int resId)
   {
     Typeface ret = null;
     try
     {
       context.getCacheDir().mkdir();
       final File output = File.createTempFile("abb_font", ".ttf");
       final byte[] buffer = new byte[4096];
       final InputStream in = context.getResources().openRawResource(resId);
       final FileOutputStream out = new FileOutputStream(output);
       for (;;)
@@ skipping 16 matching lines @@
     }
     return ret;
   }
 
   private void loadTypefaces()
   {
     final Context context = this.getActivity();
     this.loadedFonts.clear();
     for (Map.Entry<String, Integer> e : FONTS.entrySet())
     {
-      final Typeface t = typefaceFromResource(context, e.getValue().intValue());
+      final Typeface t = typefaceFromResource(context, e.getValue());
       if (t != null)
       {
         this.loadedFonts.put(e.getKey(), t);
       }
     }
   }
 
   private void loadPagesResources()
   {
     final boolean useBetaResourceList = !AppConstants.ABB_RELEASE_BUILD && BrowserAppUtils.wasInstalledFromPlayStore(getContext());
@@ skipping 11 matching lines @@
   }
 
   @Override
   public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle bundle)
   {
     final View view = inflater.inflate(R.layout.abb_start_pane, container, false);
 
     this.updateContents(view);
 
     this.getDialog().setOnKeyListener(this);
-    ((Button) view.findViewById(R.id.abb_frp_button)).setOnClickListener(this);
+    view.findViewById(R.id.abb_frp_button).setOnClickListener(this);
 
     return view;
   }
 
   @Override
   public void onActivityCreated(Bundle savedInstanceState)
   {
     super.onActivityCreated(savedInstanceState);
     final Window window = getDialog().getWindow();
     window.setBackgroundDrawable(null);
@@ skipping 25 matching lines @@
         this.currentStep--;
         this.updateContents(this.getView());
       }
       return true;
     }
     return false;
   }
 
   private static List<View> listViews(final View parent)
   {
-    final List<View> views = new ArrayList<View>();
+    final List<View> views = new ArrayList<>();
     listViews(parent, views);
     return views;
   }
 
   private static void listViews(final View parent, final List<View> views)
   {
     views.add(parent);
     if (parent instanceof ViewGroup)
     {
       final ViewGroup vg = (ViewGroup) parent;
@@ skipping 36 matching lines @@
       }
     }
   }
 
   private void setButtonText(final View view, final int viewId, final int resId)
   {
     final Button button = (Button) view.findViewById(viewId);
     button.setText(this.getString(resId));
   }
 }