Noissue - Lint adjustments

mobile/android/thirdparty/org/adblockplus/browser/SubscriptionContainer.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 31 matching lines @@
   private final Semaphore entriesReady = new Semaphore(0);
   private final List<SubscriptionContainer.Subscription> entries = new ArrayList<>();
   private final HashMap<String, SubscriptionContainer.Subscription> urlMap = new HashMap<>();
   private final List<WeakReference<SubscriptionListener>> subscriptionListeners = new ArrayList<>();
 
   private SubscriptionContainer()
   {
     // prevent external instantiation
   }
 
-  public final static SubscriptionContainer create()
+  public static SubscriptionContainer create()
   {
     return create(true);
   }
 
-  public final static SubscriptionContainer create(final boolean refresh)
+  public static SubscriptionContainer create(final boolean refresh)
   {
     final SubscriptionContainer sc = new SubscriptionContainer();
     AddOnBridge.queryValue(sc, "subscriptionsXml");
     sc.entriesReady.acquireUninterruptibly();
 
     for (final SubscriptionContainer.Subscription e : sc.entries)
     {
       sc.urlMap.put(e.url, e);
       sc.enableState.put(e.url, Boolean.FALSE);
     }
@@ skipping 29 matching lines @@
       if (this.isSubscriptionListed(e.url) == enabled)
       {
         ret.add(e);
       }
     }
     return ret;
   }
 
   public boolean isSubscriptionListed(final String url)
   {
-    return this.enableState.containsKey(url) && this.enableState.get(url).booleanValue();
+    return this.enableState.containsKey(url) && this.enableState.get(url);
   }
 
   public void changeSubscriptionState(final String url, final boolean enable)
   {
     final SubscriptionContainer.Subscription e = this.urlMap.get(url);
     if (e != null)
     {
       if (enable)
       {
         SubscriptionChangeAction.post(e, SubscriptionPreferenceCategory.subscriptionContainer,
@@ skipping 53 matching lines @@
         if ("subscription".equals(parser.getName()))
         {
           final String title = parser.getAttributeValue(null, "title");
           final String specialization = parser.getAttributeValue(null, "specialization");
           final String url = parser.getAttributeValue(null, "url");
           this.entries.add(new Subscription(title, specialization, url));
         }
         parser.next();
       }
     }
-    catch (XmlPullParserException e)
-    {
-      Log.e(TAG, "Failed to parse subscriptions.xml: " + e.getMessage(), e);
-    }
-    catch (IOException e)
+    catch (XmlPullParserException | IOException e)
     {
       Log.e(TAG, "Failed to parse subscriptions.xml: " + e.getMessage(), e);
     }
     finally
     {
       this.entriesReady.release();
     }
   }
 
   @Override
@@ skipping 55 matching lines @@
 
     @Override
     public void onApiRequestSucceeded(NativeJSObject jsObject)
     {
       switch (this.mode)
       {
         case QUERY_SUBSCRIPTION_ENABLED:
           try
           {
             this.parent.enableState.put(this.subscription.url,
-                Boolean.valueOf(AddOnBridge.getBooleanFromJsObject(jsObject, "value", false)));
+                AddOnBridge.getBooleanFromJsObject(jsObject, "value", false));
           }
           finally
           {
             this.parent.entriesReady.release();
           }
           break;
         case ENABLE_SUBSCRIPTION:
         case DISABLE_SUBSCRIPTION:
           this.parent.enableState.put(this.subscription.url, this.mode == Mode.ENABLE_SUBSCRIPTION);
           final Iterator<WeakReference<SubscriptionListener>> iterator = this.parent.subscriptionListeners.iterator();
@@ skipping 60 matching lines @@
     {
       return this.specialization + " (" + this.title + ") @ " + this.url;
     }
   }
 
   public interface SubscriptionListener
   {
     void onSubscriptionUpdated();
   }
 }