Issue 5147 - Invalidate wrapper on delete

test/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 144 matching lines @@
 
   filter1.hitCount = 432;
 
   let filter2 = Filter.fromText("someknownfilter");
   test.equal(filter2.hitCount, 432, "Known filter returned");
 
   filter2.hitCount = 234;
   test.equal(filter1.hitCount, 234, "Changing second wrapper modifies original as well");
 
   filter1.delete();
+
+  test.throws(() => { filter1.delete(); });
+  test.throws(() => { filter1.hitCount; });
+  test.throws(() => { filter1._pointer; });
+
   filter2.delete();
-
-  test.throws(() => { filter1.delete() == 0; });

[sergei, 2017/10/11 12:52:55]

What about putting them into a separate test?

[sergei, 2017/10/11 12:52:56]

IMO it would be better to remove these comparisons.

[hub, 2017/10/11 14:47:01]

I don't know was I put the '== 0' here.

I think they can be in that test. We want to test the object lifecycle and
therefor testing with invalidate them is relevant.

-  test.throws(() => { filter1.hitCount == 0; });
-  test.throws(() => { filter1._pointer == 0xdeadbeef; });

[Wladimir Palant, 2017/10/11 13:51:52]

I agree, comparisons aren't necessary. Also, you should put these before
deleting filter2 - so the instance still exists.

[hub, 2017/10/11 14:47:01]

Done.

 
   let filter3 = Filter.fromText("someknownfilter");
   test.equal(filter3.hitCount, 0, "Filter data has been reset once previous instances have been released");
   filter3.delete();
 
   test.done();
 };
 
 exports.testNormalize = function(test)
 {
@@ skipping 248 matching lines @@
     filter.hitCount++;
   }, ["filter.hitCount", "foobar"], "Increasing filter hit counts");
   checkNotifications(() =>
   {
     filter.hitCount = 0;
   }, ["filter.hitCount", "foobar"], "Resetting filter hit counts");
 
   filter.delete();
   test.done();
 };