Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: desktop-options.html

Issue 29578574: Issue 5632 - Use checkboxes for toggling acceptable ads (Closed)
Left Patch Set: Created Oct. 16, 2017, 5:36 p.m.
Right Patch Set: Fixed the duplication Created Oct. 20, 2017, 6:56 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | desktop-options.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-present eyeo GmbH 4 - Copyright (C) 2006-present eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
11 - but WITHOUT ANY WARRANTY; without even the implied warranty of 11 - but WITHOUT ANY WARRANTY; without even the implied warranty of
12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 - GNU General Public License for more details. 13 - GNU General Public License for more details.
14 - 14 -
15 - You should have received a copy of the GNU General Public License 15 - You should have received a copy of the GNU General Public License
16 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 16 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
17 --> 17 -->
18 18
19 <html> 19 <html>
20 <head> 20 <head>
21 <meta charset="utf-8"> 21 <meta charset="utf-8">
22 <title class="i18n_options_page_title"></title> 22 <title class="i18n_options_page_title"></title>
23 <link rel="stylesheet" href="skin/common.css"> 23 <link rel="stylesheet" href="skin/common.css">
24 <link rel="stylesheet" href="skin/desktop-options.css"> 24 <link rel="stylesheet" href="skin/desktop-options.css">
25 <script src="polyfill.js"></script>
25 <script src="ext/common.js"></script> 26 <script src="ext/common.js"></script>
26 <script src="ext/content.js"></script> 27 <script src="ext/content.js"></script>
27 <script src="common.js"></script> 28 <script src="common.js"></script>
28 <script src="i18n.js"></script> 29 <script src="i18n.js"></script>
29 <script src="desktop-options.js"></script> 30 <script src="desktop-options.js"></script>
30 </head> 31 </head>
31 <body data-tab="general"> 32 <body data-tab="general">
32 <!-- Navigation sidebar --> 33 <!-- Navigation sidebar -->
33 <div id="sidebar"> 34 <div id="sidebar">
34 <div class="fixed"> 35 <div class="fixed">
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 <li> 101 <li>
101 <button id="acceptable-ads-allow" data-action="switch-acceptable -ads" type="button" role="checkbox" name="acceptable-ads" value="ads"></button> 102 <button id="acceptable-ads-allow" data-action="switch-acceptable -ads" type="button" role="checkbox" name="acceptable-ads" value="ads"></button>
102 <label for="acceptable-ads-allow" class="i18n_options_acceptable Ads_ads_label"></label> 103 <label for="acceptable-ads-allow" class="i18n_options_acceptable Ads_ads_label"></label>
103 <p id="enable-acceptable-ads-description" class="i18n_options_ac ceptableAds_ads_description_1"></p> 104 <p id="enable-acceptable-ads-description" class="i18n_options_ac ceptableAds_ads_description_1"></p>
104 <p class="i18n_options_acceptableAds_ads_description_2"></p> 105 <p class="i18n_options_acceptableAds_ads_description_2"></p>
105 </li> 106 </li>
106 <ul> 107 <ul>
107 <li> 108 <li>
108 <button id="acceptable-ads-privacy-allow" data-action="switch- acceptable-ads" type="button" role="checkbox" name="acceptable-ads" value="priva cy"></button> 109 <button id="acceptable-ads-privacy-allow" data-action="switch- acceptable-ads" type="button" role="checkbox" name="acceptable-ads" value="priva cy"></button>
109 <label for="acceptable-ads-privacy-allow" class="i18n_options_ acceptableAds_privacy_label"></label> 110 <label for="acceptable-ads-privacy-allow" class="i18n_options_ acceptableAds_privacy_label"></label>
110 <span class="i18n_options_new_label new"></span> 111 <p>
111 <p id="enable-acceptable-ads-privacy-description" class="i18n_ options_acceptableAds_privacy_description"></p> 112 <a id="enable-acceptable-ads-privacy-description" class="i18 n_options_acceptableAds_privacy_description"></a>
113 </p>
112 <p id="dnt" class="i18n_options_acceptableAds_dnt_notification "></p> 114 <p id="dnt" class="i18n_options_acceptableAds_dnt_notification "></p>
113 </li> 115 </li>
114 </ul> 116 </ul>
115 </ul> 117 </ul>
116 </form> 118 </form>
117 </section> 119 </section>
118 <section class="cols"> 120 <section class="cols">
119 <header> 121 <header>
120 <h2 class="i18n_options_language_header"></h2> 122 <h2 class="i18n_options_language_header"></h2>
121 <p class="i18n_options_language_description"></p> 123 <p class="i18n_options_language_description"></p>
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 </div> 400 </div>
399 <!-- Notification --> 401 <!-- Notification -->
400 <div id="notification" aria-hidden="true" aria-live="polite"> 402 <div id="notification" aria-hidden="true" aria-live="polite">
401 <strong id="notification-text"></strong> 403 <strong id="notification-text"></strong>
402 <button id="hide-notification" data-action="hide-notification"> 404 <button id="hide-notification" data-action="hide-notification">
403 <span class="i18n_options_notification_hide sr-only"></span> 405 <span class="i18n_options_notification_hide sr-only"></span>
404 </button> 406 </button>
405 </div> 407 </div>
406 </body> 408 </body>
407 </html> 409 </html>
LEFTRIGHT
« no previous file | desktop-options.js » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld