Noissue - Removed website-default container widths

static/scss/_base.scss

 // This file is part of website-defaults
 // Copyright (C) 2016-present eyeo GmbH
 //
 // website-defaults is free software: you can redistribute it and/or
 // modify it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // website-defaults is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 // GNU General Public License for more details.
 //
 // You should have received a copy of the GNU General Public License
 // along with website-defaults.  If not, see <http://www.gnu.org/licenses/>.
 
 /*******************************************************************************
  * Base styles
  ******************************************************************************/
 
 html
 {
   color: $primary;
   background-color: $primary-light;
   font-family: $primary-font;
   line-height: 1.5;
 }
 
 /**
- * Stretch content full-width
- */
-.full-width
-{
-  display: block;
-  width: 100%;
-  margin: $small-space 0px;
-}
-
-/**
  * Center content within a (responsive) fixed width
  */
 .container
 {
-  width: $container-max-width;

[ire, 2017/10/17 17:34:37]

Since this is being applied to width, I think the variable name should be
$container-width. Otherwise, it should be applied to the `max-width` property
instead.

[juliandoucette, 2017/10/18 13:27:28]

Acknowledged.

+  width: $container-width;
   max-width: 100%;
-  margin: 0px auto;
-  padding: 0px $small-space;

[ire, 2017/10/17 17:34:37]

NIT: I think this space should be larger on bigger devices.  

Suggest: > $tablet-breakpoint = $medium-space

[juliandoucette, 2017/10/18 13:27:28]

Acknowledged.

[juliandoucette, 2017/10/18 13:44:33]

I'm skeptical about $tablet-breakpoint because it's hard to fit 2 columns (or
worse three) on tablets. I think that $large-desktop-width is the safest bet
because wide screens (in particular) can afford wide margins (padding). 

How does this affect Help Center? e.g. Are there supposed to be (or should there
be) wider margins anywhere? 

+  margin-right: auto;
+  margin-left: auto;
+  padding-right: $small-space;
+  padding-left: $small-space;
 }
-
-.clearfix:after,
-.clearfix:before
-{
-  display: table;
-  content: " ";
-}
-
-.clearfix:after
-{
-  clear: both;
-}