Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: static/scss/_base.scss

Issue 29581874: Noissue - Removed website-default container widths (Closed) Base URL: https://hg.adblockplus.org/website-defaults
Patch Set: Created Oct. 17, 2017, 3:13 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | static/scss/_variables.scss » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: static/scss/_base.scss
===================================================================
--- a/static/scss/_base.scss
+++ b/static/scss/_base.scss
@@ -36,46 +36,22 @@
margin: $small-space 0px;
}
/**
* Center content within a (responsive) fixed width
*/
.container
{
- width: $phone-width;
+ width: $container-max-width;
ire 2017/10/17 17:34:37 Since this is being applied to width, I think the
juliandoucette 2017/10/18 13:27:28 Acknowledged.
max-width: 100%;
margin: 0px auto;
padding: 0px $small-space;
ire 2017/10/17 17:34:37 NIT: I think this space should be larger on bigger
juliandoucette 2017/10/18 13:27:28 Acknowledged.
juliandoucette 2017/10/18 13:44:33 I'm skeptical about $tablet-breakpoint because it'
}
-@media(min-width: $tablet-breakpoint)
-{
- .container
- {
- width: $tablet-width;
- }
-}
-
-@media(min-width: $desktop-breakpoint)
-{
- .container
- {
- width: $desktop-width;
- }
-}
-
-@media(min-width: $large-desktop-breakpoint)
-{
- .container
- {
- width: $large-desktop-width;
- }
-}
-
.clearfix:after,
.clearfix:before
{
display: table;
content: " ";
}
.clearfix:after
« no previous file with comments | « no previous file | static/scss/_variables.scss » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld