Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: desktop-options.js

Issue 29584714: Issue 5874 - Sync strings with the agencies translations (Closed)
Patch Set: Separate Learn more from strings Created Oct. 23, 2017, 2:44 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: desktop-options.js
===================================================================
--- a/desktop-options.js
+++ b/desktop-options.js
@@ -376,6 +376,7 @@
collections.filterLists = new Collection([
{
id: "all-filter-lists-table",
+ emptyTexts: ["options_filterList_empty"],
useOriginalTitle: true
}
]);
@@ -903,6 +904,7 @@
E("whitelisting-add-button").disabled = !e.target.value;
}, false);
+ // General tab
getDocLink("contribute", (link) =>
{
E("contribute").href = link;
@@ -920,6 +922,12 @@
setLinks("dnt", url);
});
+ // Whitelisted tab
+ getDocLink("whitelist", (link) =>
+ {
+ E("whitelist-learn-more").href = link;
+ });
+
// Advanced tab
let customize = document.querySelectorAll("#customize li[data-pref]");
customize = Array.prototype.map.call(customize, (checkbox) =>
@@ -949,7 +957,7 @@
getDocLink("subscriptions", (link) =>
{
- setLinks("filter-lists-description", link);
+ E("filter-lists-learn-more").setAttribute("href", link);
});
E("custom-filters-raw").setAttribute("placeholder",

Powered by Google App Engine
This is Rietveld