Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: issue-reporter.js

Issue 29587596: Noissue - Address eslint warnings in the issue reporter (Closed) Base URL: https://hg.adblockplus.org/adblockplusui
Left Patch Set: Created Oct. 24, 2017, 10:37 a.m.
Right Patch Set: Changed indentation Created Oct. 24, 2017, 12:17 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 guid: uuidString, 352 guid: uuidString,
353 lang: reportData.getElementsByTagName("adblock-plus")[0] 353 lang: reportData.getElementsByTagName("adblock-plus")[0]
354 .getAttribute("locale") 354 .getAttribute("locale")
355 }); 355 });
356 let url = "https://reports.adblockplus.org/submitReport?" + params; 356 let url = "https://reports.adblockplus.org/submitReport?" + params;
357 357
358 let reportSent = event => 358 let reportSent = event =>
359 { 359 {
360 let success = false; 360 let success = false;
361 let errorMessage = browser.i18n.getMessage( 361 let errorMessage = browser.i18n.getMessage(
362 "filters_subscription_lastDownload_connectionError" 362 "filters_subscription_lastDownload_connectionError"
Manish Jethani 2017/10/24 12:04:14 Even though ESLint complain I think this is suppos
Wladimir Palant 2017/10/24 12:17:27 Done.
363 ); 363 );
364 try 364 try
365 { 365 {
366 success = request.status == 200; 366 success = request.status == 200;
367 if (request.status != 0) 367 if (request.status != 0)
368 errorMessage = request.status + " " + request.statusText; 368 errorMessage = request.status + " " + request.statusText;
369 } 369 }
370 catch (e) 370 catch (e)
371 { 371 {
372 // Getting request status might throw if no connection was established 372 // Getting request status might throw if no connection was established
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
446 progress.value = event.loaded; 446 progress.value = event.loaded;
447 } 447 }
448 }); 448 });
449 request.send(serializeReportData()); 449 request.send(serializeReportData());
450 } 450 }
451 451
452 function leaveSendPage() 452 function leaveSendPage()
453 { 453 {
454 window.close(); 454 window.close();
455 } 455 }
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld