Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: issue-reporter.js

Issue 29587629: Issue 5896 - Simplify error handling in the issue reporter (Closed) Base URL: https://hg.adblockplus.org/adblockplusui/
Patch Set: Created Oct. 24, 2017, 12:13 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 retrievePlatformInfo(), 220 retrievePlatformInfo(),
221 retrieveTabURL(tabId), 221 retrieveTabURL(tabId),
222 retrieveSubscriptions() 222 retrieveSubscriptions()
223 ]; 223 ];
224 return Promise.all(handlers); 224 return Promise.all(handlers);
225 }).then(() => 225 }).then(() =>
226 { 226 {
227 setCurrentPage("typeSelectorPage"); 227 setCurrentPage("typeSelectorPage");
228 }).catch(e => 228 }).catch(e =>
229 { 229 {
230 if (!e.name && e.message) 230 console.error(e);
231 e = e.message;
232 alert(e); 231 alert(e);
233 window.close(); 232 window.close();
234 }); 233 });
235 } 234 }
236 235
237 function initTypeSelector() 236 function initTypeSelector()
238 { 237 {
239 document.getElementById("typeFalsePositive").focus(); 238 document.getElementById("typeFalsePositive").focus();
240 239
241 240
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
475 progress.value = event.loaded; 474 progress.value = event.loaded;
476 } 475 }
477 }); 476 });
478 request.send(serializeReportData()); 477 request.send(serializeReportData());
479 } 478 }
480 479
481 function leaveSendPage() 480 function leaveSendPage()
482 { 481 {
483 window.close(); 482 window.close();
484 } 483 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld