Issue 104 - added checktranslations function

localeTools.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import re
 import os
 import sys
 import codecs
 import json
 import urlparse
@@ skipping 285 matching lines @@
         if not os.path.exists(baseDir):
             continue
         for file in os.listdir(baseDir):
             path = os.path.join(baseDir, file)
             valid_extension = file.endswith('.json')
             if os.path.isfile(path) and valid_extension and not file in files:
                 os.remove(path)
 
 
 def check_translations(localeConfig):
-    path = localeConfig['base_path']
-    json_fld = path.rsplit('/', 1)[1]

[tlucas, 2017/10/29 23:10:04]

Use os.path.split() to split paths.

a) This will succeed, no matter what operating system the user is running
b) The behavior of os.path.plit('/foo/bar/baz/') -> ['/foo/bar', 'baz'] is
exactly what you are trying to accomplish here.

[erick, 2017/10/31 04:30:02]

I receive "AttributeError: 'tuple' object has no attribute 'endswith'", when I
can't use os.path.split() and var.rsplit() is not sufficient, do I have other
options? The problem came up, when I try to join the strings to the path
together. Line 309

[tlucas, 2017/10/31 07:43:09]

The error message pointed you to passing a tuple, instead of string. I guess you
forgot the access operator here?

However: you do NOT need to split anything, since base_path + locale already is
the correct folder, am i right?

[erick, 2017/11/06 06:29:43]

Done.

-    for locale in os.listdir('_locales/'):

[tlucas, 2017/10/29 23:10:04]

As pointed in out in the last comment '_locales' is not universal. Additionally,
you are introducing json_fld, but your are not using it anywhere.

your variable "path" should be your starting point - 

plaase consult
https://hg.adblockplus.org/buildtools/file/tip/packagerChrome.py#l214 (and
surrounding) for an example on how to validly determine locale filenames.

[erick, 2017/10/31 04:30:02]

Done.

-        jsonpath = os.path.join('_locales/', locale, 'messages.json')
+    base_path = localeConfig['base_path']
+    for locale in os.listdir(base_path):
+        jsonpath = os.path.join(base_path, locale, 'messages.json')
 
         if not os.path.exists(jsonpath):
             continue
 
         with codecs.open(jsonpath, 'rb', encoding='utf-8') as f:
             try:
                 data = json.load(f)
-            except ValueError, e:
-                print >>sys.stderr, '%s -> File is not valid. %s' % e
-
-        for key, value in data.iteritems():
-            variables = set()
-            max_length = value.get('maxLength')
-            length = len(value['message'])
-            if max_length is not None and length > max_length or length > 160:
-                print >>sys.stderr, (
-                    '{} {} -> translation might be too long. More then 160 '
-                    'chars or maxLength exceeded').format(locale, key)
-
-            for match in re.finditer(r'\$(\S+?)\$', value['message']):
-                variables.add(match.group(1))
-            expected = set(value.get('placeholders', {}).iterkeys())
-            if variables != expected:
-                print >>sys.stderr, (

[tlucas, 2017/10/29 23:10:04]

nit: this is rather awkward to read.

maybe something like

...
                             ... Variables: {}'
                 ).format(locale, key, variables, expected)

?

[erick, 2017/10/31 04:30:02]

Done.

-                    '{} {}: Variables used are {} '
-                    'expected. Variables: {}').format(
-                    locale, key, variables, expected)
+                for key, value in data.iteritems():
+                    variables = set()
+                    max_length = value.get('maxLength')
+                    length = len(value['message'])
+                    if (max_length is not None and
+                            length > max_length or length > 160):
+                        print >>sys.stderr, (
+                            '{} {} -> translation might be too long.'
+                            'More then 160 chars or maxLength exceeded'
+                        ).format(locale, key)
+
+                    for match in re.finditer(r'\$(\S+?)\$', value['message']):
+                        variables.add(match.group(1))
+                    expected = set(value.get('placeholders', {}).iterkeys())
+                    if variables != expected:
+                        print >>sys.stderr, (
+                            '{} {}: Variables used are {} '
+                            'expected. Variables: {}'
+                        ).format(locale, key, variables, expected)
+            except ValueError:
+                print >>sys.stderr, locale + ', messages.json is not valid.'