Issue 5919 - Adjust our code to the new messaging system

adblockplus/Api.jsm

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 213 matching lines @@
     }
   },
   initCommunication: function()
   {
     initFilterListeners();
 
     EventDispatcher.instance.registerListener((event, data, callback) =>
     {
       if (!data)
       {
         callback.onError("malformed request");

[anton, 2017/10/30 13:16:55]

should not `return` be added here?

[diegocarloslima, 2017/10/30 13:40:11]

Acknowledged.

+        return;
       }
 
       if (!this.filtersLoaded)
       {
         callback.onError("filters not loaded");

[anton, 2017/10/30 13:16:55]

should not `return` be added here?

[diegocarloslima, 2017/10/30 13:40:11]

Acknowledged.

+        return;
       }
 
       switch (data["action"])
       {
         case "getAdblockPlusEnabled":
           callback.onSuccess({"value": this.adblockPlusEnabled});
           return;
         case "setAdblockPlusEnabled":
           if ("enable" in data)
           {
@@ skipping 62 matching lines @@
             this.whitelistSite(data["url"], data["whitelisted"]);
             callback.onSuccess({});
             return;
           }
           break;
       }
       callback.onError("malformed request");
     }, "AdblockPlus:Api");
   }
 };