Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: packagerChrome.py

Issue 29589561: Issue 5916 - Locale strings are broken in adblockpluschrome when building from Windows (Closed)
Patch Set: Created Oct. 26, 2017, 9:12 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packagerChrome.py
===================================================================
--- a/packagerChrome.py
+++ b/packagerChrome.py
@@ -12,6 +12,7 @@
import subprocess
import sys
import random
+import posixpath
from packager import (readMetadata, getDefaultFileName, getBuildVersion,
getTemplate, Files)
@@ -214,7 +215,7 @@
*filename.split('/'))):
keys = item[1]
locale = sourceFile.split(os.path.sep)[-2]
- targetFile = os.path.join('_locales', locale, 'messages.json')
+ targetFile = posixpath.join('_locales', locale, 'messages.json')
Oleksandr 2017/10/26 09:16:02 A more generic approach would be to not rely on an
Wladimir Palant 2017/10/26 09:22:13 ZIP archives (which is what we are talking about h
data = json.loads(files.get(targetFile, '{}').decode('utf-8'))
try:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld