Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: inject.preload.js

Issue 29590611: Issue 5953 - Bypass site CSP for script injection in Firefox (Closed)
Patch Set: Actually inject the right code Created Oct. 27, 2017, 4 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: inject.preload.js
===================================================================
--- a/inject.preload.js
+++ b/inject.preload.js
@@ -393,13 +393,17 @@ if (document instanceof HTMLDocument)
let sandbox = window.frameElement &&
window.frameElement.getAttribute("sandbox");
if (typeof sandbox != "string" || /(^|\s)allow-scripts(\s|$)/i.test(sandbox))
{
let script = document.createElement("script");
script.type = "application/javascript";
script.async = false;
- script.textContent = "(" + injected + ")('" + randomEventName + "');";
+ let code = "(" + injected + ")('" + randomEventName + "');";
+ let blob = new Blob([code], { type: "text/javascript" });
Manish Jethani 2017/10/27 20:18:56 As per the style guide [1] we don't add spaces imm
+ let url = URL.createObjectURL(blob);
+ script.src = url;
document.documentElement.appendChild(script);
document.documentElement.removeChild(script);
+ URL.revokeObjectURL(url);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld