static/scss/utilities/_responsive-widths.scss - Issue 29603821: Noissue - Separated website-default utilities

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: static/scss/utilities/_responsive-widths.scss

Issue 29603821: Noissue - Separated website-default utilities (Closed) Base URL: https://hg.adblockplus.org/website-defaults

Patch Set: Created Nov. 10, 2017, 2:04 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // This file is part of website-defaults

	2 // Copyright (C) 2016-present eyeo GmbH

	3 //

	4 // website-defaults is free software: you can redistribute it and/or

	5 // modify it under the terms of the GNU General Public License as published by

	6 // the Free Software Foundation, either version 3 of the License, or

	7 // (at your option) any later version.

	8 //

	9 // website-defaults is distributed in the hope that it will be useful,

	10 // but WITHOUT ANY WARRANTY; without even the implied warranty of

	11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

	12 // GNU General Public License for more details.

	13 //

	14 // You should have received a copy of the GNU General Public License

	15 // along with website-defaults. If not, see <http://www.gnu.org/licenses/>.

	16

	17 /**
	ire 2017/11/13 08:33:38 NIT: Change the comment style? NIT: Change the comment style? juliandoucette 2017/11/13 12:32:59 This is a JSDoc comment. It's meant to describe wh Show quoted text On 2017/11/13 08:33:38, ire wrote: > NIT: Change the comment style? This is a JSDoc comment. It's meant to describe what the class below does; not categorize (like the other full-line comments). ire 2017/11/14 07:14:51 Ack. NIT: I think we typically start the comment Show quoted text On 2017/11/13 12:32:59, juliandoucette wrote: > On 2017/11/13 08:33:38, ire wrote: > > NIT: Change the comment style? > > This is a JSDoc comment. It's meant to describe what the class below does; not > categorize (like the other full-line comments). Ack. NIT: I think we typically start the comment on the first line juliandoucette 2017/11/17 14:52:12 Not doc comments. e.g. https://hg.adblockplus.org/ Show quoted text On 2017/11/14 07:14:51, ire wrote: > NIT: I think we typically start the comment on the first line Not doc comments. e.g. https://hg.adblockplus.org/adblockplus/file/tip/lib/io.js#l172
	18 * Stretch content (e.g. images) full-width

	19 */

	20 .full-width

	21 {

	22 display: block;

	23 width: 100%;

	24 }

	25

	26 /**

	27 * Center content within a (responsive) fixed width

	28 */

	29 .container
	ire 2017/11/13 08:33:38 NIT: Is the .container class a "responsive width"? NIT: Is the .container class a "responsive width"? juliandoucette 2017/11/13 12:33:00 It was when it had responsive fixed widths. Now... Show quoted text On 2017/11/13 08:33:38, ire wrote: > NIT: Is the .container class a "responsive width"? It was when it had responsive fixed widths. Now... sortof? It depends if you agree with the phrasing "full-width responsive" (which I just made up) meaning full-width on devices smaller than the max-width. ire 2017/11/14 07:14:50 One the one hand the phrasing "full-width-responsi Show quoted text On 2017/11/13 12:33:00, juliandoucette wrote: > On 2017/11/13 08:33:38, ire wrote: > > NIT: Is the .container class a "responsive width"? > > It was when it had responsive fixed widths. Now... sortof? > > It depends if you agree with the phrasing "full-width responsive" (which I just > made up) meaning full-width on devices smaller than the max-width. One the one hand the phrasing "full-width-responsive" makes sense literally, but because I already have a pre-existing definition of a "container", it kinda clashes in my mind. I think it's fine to leave this here because I can't think of a better place to put it.
	30 {

	31 width: $container-width;

	32 max-width: 100%;

	33 margin-right: auto;

	34 margin-left: auto;

	35 padding-right: $small-space;

	36 padding-left: $small-space;

	37 }

OLD	NEW