Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: templates/article.tmpl

Issue 29607560: Issue 6003 - Better handling of no-content-for-platform-message on help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Rebase Created Nov. 14, 2017, 3:27 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% extends "templates/minimal" %} 1 {% extends "templates/minimal" %}
2 2
3 {% set product = products[product_id] %} 3 {% set product = products[product_id] %}
4 4
5 {% block body %} 5 {% block body %}
6 <nav aria-label="{{ "Breadcrumb" | translate("breadcrumb-label", "Label") }}" cl ass="breadcrumb"> 6 <nav aria-label="{{ "Breadcrumb" | translate("breadcrumb-label", "Label") }}" cl ass="breadcrumb">
7 <ol class="container large-desktop-width clearfix" itemscope itemtype="http:// schema.org/BreadcrumbList"> 7 <ol class="container large-desktop-width clearfix" itemscope itemtype="http:// schema.org/BreadcrumbList">
8 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m"> 8 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m">
9 <a class="has-pre-icon" itemscope itemtype="http://schema.org/Thing" itemp rop="item" href="{{ product.slug }}"> 9 <a class="has-pre-icon" itemscope itemtype="http://schema.org/Thing" itemp rop="item" href="{{ product.slug }}">
10 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) }}">< /span> 10 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) }}">< /span>
(...skipping 18 matching lines...) Expand all
29 <h1 class="has-pre-icon"> 29 <h1 class="has-pre-icon">
30 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) } }"></span> 30 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) } }"></span>
31 {{ title | translate( get_page_name(page) + "-title", "Article title ") }} 31 {{ title | translate( get_page_name(page) + "-title", "Article title ") }}
32 </h1> 32 </h1>
33 </header> 33 </header>
34 34
35 {% if hide_browser_selector is not defined %} 35 {% if hide_browser_selector is not defined %}
36 <div class="article-browser-selector"> 36 <div class="article-browser-selector">
37 <? include browser-select ?> 37 <? include browser-select ?>
38 </div> 38 </div>
39
40 <div id="no-content-for-platform-message" class="content" aria-hidden="t rue" hidden>
juliandoucette 2017/11/15 13:27:45 I think that aria-hidden and hidden is redundant.
ire 2017/11/15 16:57:30 You're right. I wasn't sure about this myself. Tha
41 <p>{{ "Unfortunately, there is no content specific to your current bro wser. Please choose a different browser from the list below:" | translate("no-co ntent-for-platform-message", "paragraph") }}</p>
juliandoucette 2017/11/15 13:27:45 NIT: This message doesn't make sense when you sele
ire 2017/11/15 16:57:30 Why doesn't it make sense? And do you have a sugge
juliandoucette 2017/11/15 18:03:33 "Your current browser" means "the browser that you
ire 2017/11/27 18:26:45 Ack. I understand.
42 <ul>
43 {% for browser in browsers %}
44 <li class="{{ browser.id }}">
45 <button type="button" class="btn-link">
46 {{ browser.name | translate(browser.id + "-name") }}
47 </button>
48 </li>
49 {% endfor %}
50 </ul>
51 </div>
39 {% endif %} 52 {% endif %}
40 53
41 <div class="article-body content"> 54 <div class="article-body content">
42 {{ body | safe }} 55 {{ body | safe }}
43 </div> 56 </div>
44 </article> 57 </article>
45 </div> 58 </div>
46 <aside class="section column one-third"> 59 <aside class="section column one-third">
47 <? include product-topics-accordion ?> 60 <? include product-topics-accordion ?>
48 </aside> 61 </aside>
49 </div> 62 </div>
50 </main> 63 </main>
51
52 <script id="no-content-for-platform-message" type="text/template">
53 <p>{{ "Unfortunately, there is no content specific for your current browser. P lease use the dropdown menu above to choose a different browser." | translate("n o-content-for-platform-message", "paragraph") }}</p>
54 </script>
55 {% endblock %} 64 {% endblock %}
56 65
57 {% block footer %} 66 {% block footer %}
58 <? include contact ?> 67 <? include contact ?>
59 {% endblock %} 68 {% endblock %}
60 69
61 {% block scripts %} 70 {% block scripts %}
62 <script src="/js/vendor/bowser.js"></script> 71 <script src="/js/vendor/bowser.js"></script>
63 {% endblock %} 72 {% endblock %}
OLDNEW
« static/scss/content/_typography.scss ('K') | « static/scss/content/_typography.scss ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld