Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: packagerChrome.py

Issue 29611593: Issue 5996 - Release consistent versions across WebExtensions (Closed) Base URL: https://codereview.adblockplus.org/29609559/
Patch Set: Addressing comments Created Nov. 28, 2017, 1:27 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packager.py ('k') | releaseAutomation.py » ('j') | releaseAutomation.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packagerChrome.py
diff --git a/packagerChrome.py b/packagerChrome.py
index 3d94ad041dfd31eccd669ca38258a90de6743336..4d0d1d9197783b55aa003c6a7fe0be1866a97332 100644
--- a/packagerChrome.py
+++ b/packagerChrome.py
@@ -15,7 +15,7 @@ import random
import posixpath
from packager import (readMetadata, getDefaultFileName, getBuildVersion,
- getTemplate, Files)
+ getTemplate, get_extension, Files)
defaultLocale = 'en_US'
@@ -355,10 +355,7 @@ def createBuild(baseDir, type='chrome', outFile=None, buildNum=None, releaseBuil
version = getBuildVersion(baseDir, metadata, releaseBuild, buildNum)
if outFile == None:
- if type == 'gecko':
- file_extension = 'xpi'
- else:
- file_extension = 'crx' if keyFile else 'zip'
+ file_extension = get_extension(type, keyFile is not None)
outFile = getDefaultFileName(metadata, version, file_extension)
params = {
« no previous file with comments | « packager.py ('k') | releaseAutomation.py » ('j') | releaseAutomation.py » ('J')

Powered by Google App Engine
This is Rietveld