includes/reinstall.tmpl - Issue 29611624: Issue 6047 - Updated templates and uninstalled pages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: includes/reinstall.tmpl

Issue 29611624: Issue 6047 - Updated templates and uninstalled pages (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org

Patch Set: Addressed #14 Created Dec. 14, 2017, 6:39 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <aside id="reinstall" class="bg-accent" >
	ire 2017/12/18 08:43:07 NIT: Extra space before closing ">" NIT: Extra space before closing ">" juliandoucette 2017/12/18 12:58:11 Acknowledged. Show quoted text On 2017/12/18 08:43:07, ire wrote: > NIT: Extra space before closing ">" Acknowledged.
	2 <div class="container content">

	3 <p class="lead">

	4 {{ "Did you uninstall Adblock Plus by accident?" \| translate("reinstall-head line", "Text next to the Reinstallation button") }}

	5 {{ "index" \| linkify(class="button inverse") }}{{ "Reinstall Now" \| translat e("reinstall", "Reinstall button text") }}</a>
	ire 2017/12/18 08:43:07 There's no closing tag for the <p> here (but for There's no closing tag for the <p> here (but for some reason it's added to the generated site. does the cms do this?) juliandoucette 2017/12/18 12:58:11 Nope (check the source in your browser). Closing t Show quoted text On 2017/12/18 08:43:07, ire wrote: > There's no closing tag for the <p> here > > (but for some reason it's added to the generated site. does the cms do this?) Nope (check the source in your browser). Closing tags are optional in HTML5 (most of the time) / modern browsers have pretty good broken HTML heuristics. Anyway, thank you for pointing this out! I will fix it. ire 2017/12/20 08:12:57 Cool, TIL! Show quoted text On 2017/12/18 12:58:11, juliandoucette wrote: > On 2017/12/18 08:43:07, ire wrote: > > There's no closing tag for the <p> here > > > > (but for some reason it's added to the generated site. does the cms do this?) > > Nope (check the source in your browser). Closing tags are optional in HTML5 > (most of the time) / modern browsers have pretty good broken HTML heuristics. > > Anyway, thank you for pointing this out! I will fix it. Cool, TIL!
	6 </div>

	7 </aside>

OLD	NEW

« no previous file with comments | « includes/polyfills.tmpl ('k') | includes/scripts.tmpl » ('j') | no next file with comments »