Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: composer.js

Issue 29613777: Issue 5817 - Retry sending suggested filters to block element dialog (Closed)
Left Patch Set: Created Nov. 21, 2017, 3:34 p.m.
Right Patch Set: Rebased, addressed Wladimir's feedback Created Nov. 23, 2017, 12:29 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « composer.html ('k') | lib/filterComposer.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 92
93 ext.onMessage.addListener((msg, sender, sendResponse) => 93 ext.onMessage.addListener((msg, sender, sendResponse) =>
94 { 94 {
95 switch (msg.type) 95 switch (msg.type)
96 { 96 {
97 case "composer.dialog.init": 97 case "composer.dialog.init":
98 targetPageId = msg.sender; 98 targetPageId = msg.sender;
99 let filtersTextArea = document.getElementById("filters"); 99 let filtersTextArea = document.getElementById("filters");
100 filtersTextArea.value = msg.filters.join("\n"); 100 filtersTextArea.value = msg.filters.join("\n");
101 filtersTextArea.disabled = false; 101 filtersTextArea.disabled = false;
102 $("#addButton").button("option", "disabled", false);
kzar 2017/11/23 12:31:53 I'm unhappy to add new code that uses jQuery howev
102 break; 103 break;
103 case "composer.dialog.close": 104 case "composer.dialog.close":
104 closeMe(); 105 closeMe();
105 break; 106 break;
106 } 107 }
107 }); 108 });
108 109
109 window.removeEventListener("load", init); 110 window.removeEventListener("load", init);
110 } 111 }
111 window.addEventListener("load", init, false); 112 window.addEventListener("load", init, false);
LEFTRIGHT

Powered by Google App Engine
This is Rietveld