Issue 6090 - Allow use of console to be seen during tests

test/filterStorage.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
-const {createSandbox, maybeExpectError} = require("./_common");
+const {createSandbox, silenceAssertionOutput} = require("./_common");
 
 let Filter = null;
 let FilterNotifier = null;
 let FilterStorage = null;
 let Subscription = null;
 
 exports.setUp = function(callback)
 {
   let sandboxedRequire = createSandbox();
 
@@ skipping 146 matching lines @@
 
   FilterStorage.removeSubscription(subscription2);
   compareSubscriptionList(test, "Remove", [subscription3, subscription1]);
 
   changes = [];
   test.ok(FilterStorage.moveSubscription(subscription3, subscription2), "Move before removed subscription succeeded");
   compareSubscriptionList(test, "Move before removed subscription", [subscription1, subscription3]);
   test.deepEqual(changes, ["subscription.moved http://test3/"], "Received changes");
 
   changes = [];
-  maybeExpectError(
-    "Attempt to move a subscription that is not in the list",
-    () => test.ok(!FilterStorage.moveSubscription(subscription2), "Move of removed subscription failed")

[sergei, 2017/11/24 10:15:28]

What about being more strict and wrap only the call of
`FilterStorage.moveSubscription(subscription2)`?

test.ok(!maybeExpectError(() => FilterStorage.moveSubscription(subscription2),
                          "Attempt to move a subscription that is not in the
list"),
        "Move of removed subscription failed");

[hub, 2017/11/24 15:48:59]

Done.

-  );
+  test.ok(!silenceAssertionOutput(
+    () => FilterStorage.moveSubscription(subscription2),
+    "Attempt to move a subscription that is not in the list"
+  ), "Move of removed subscription failed");
   compareSubscriptionList(test, "Move of removed subscription", [subscription1, subscription3]);
   test.deepEqual(changes, [], "Received changes");
 
   subscription1.delete();
   subscription2.delete();
   subscription3.delete();
 
   test.done();
 };
 
@@ skipping 96 matching lines @@
     "filter.removed foo 2 1"
   ], "Received changes");
 
   changes = [];
   removeFilter("foo");
   compareFiltersList(test, "Removing unknown filter", [[], ["@@bar", "foo##bar", "foo#@#bar"], ["!foobar"]]);
   test.deepEqual(changes, [], "Received changes");
 
   test.done();
 };