Issue 5146 - Part 2: Process http response in C++

lib/synchronizer.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 127 matching lines @@
 
   _onDownloadStarted(downloadable)
   {
     let subscription = Subscription.fromURL(downloadable.url);
     FilterNotifier.triggerListeners("subscription.downloading", subscription);
   },
 
   _onDownloadSuccess(downloadable, responseText, errorCallback,
                      redirectCallback)
   {
-    let lines = responseText.split(/[\r\n]+/);
-    let headerMatch = /\[Adblock(?:\s*Plus\s*([\d.]+)?)?\]/i.exec(lines[0]);
-    if (!headerMatch)
-      return errorCallback("synchronize_invalid_data");
-    let minVersion = headerMatch[1];
-
     let parser = DownloadableSubscription.parseDownload();
 
-    // Process filters
-    for (let line of lines)
-      parser.process(line);
+    if (!parser.process(responseText))
+    {
+      let {error} = parser;
+      parser.delete();
+      return errorCallback(error);
+    }
 
     if (!parser.verifyChecksum())
       return errorCallback("synchronize_checksum_mismatch");
 
     if (parser.redirect)
     {
       let {redirect} = parser;
       parser.delete();
       return redirectCallback(redirect);
     }
@@ skipping 35 matching lines @@
       }
       catch (e)
       {
         url = null;
       }
 
       if (url && (url.protocol == "http:" || url.protocol == "https:"))
         subscription.homepage = url.href;
     }
 
-    if (minVersion)
-      subscription.requiredVersion = minVersion;
-    else
-      delete subscription.requiredVersion;
-
     let expirationInterval = DEFAULT_EXPIRATION_INTERVAL;
     let expiration = parser.finalize(subscription);
     if (expiration != 0)
       expirationInterval = expiration;
 
     let [
       softExpiration,
       hardExpiration
     ] = downloader.processExpirationInterval(expirationInterval);
     subscription.softExpiration = Math.round(softExpiration / MILLIS_IN_SECOND);
@@ skipping 64 matching lines @@
               Array.from(subscription.filters, f => f.text).join("\n");
             redirectCallback("data:text/plain," + encodeURIComponent(data));
           }
         }, false);
         request.send(null);
       }
     }
   }
 };
 Synchronizer.init();