Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: FavIconTests/FavIconsTests.swift

Issue 29664569: Favicon: Issue 6245 - SwiftLinted project files (Closed)
Patch Set: Added sorted_imports ignore command to FavIconTests class Created Feb. 19, 2018, 10:32 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « FavIcon/Utils.swift ('k') | FavIconTests/HTMLDocumentTests.swift » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: FavIconTests/FavIconsTests.swift
diff --git a/FavIconTests/FavIconsTests.swift b/FavIconTests/FavIconsTests.swift
index f34edb7a798547f074ae014fbefab7659d8990b6..d56d901e69e41b78f9804ff0e3e94dfdcd7accbd 100644
--- a/FavIconTests/FavIconsTests.swift
+++ b/FavIconTests/FavIconsTests.swift
@@ -15,17 +15,18 @@
// limitations under the License.
//
+// swiftlint:disable sorted_imports
+
import XCTest
@testable import FavIcon
#if os(iOS)
-import UIKit
+ import UIKit
#elseif os(OSX)
-import Cocoa
+ import Cocoa
#endif
// swiftlint:disable function_body_length
-// swiftlint:disable line_length
class FavIconTests: XCTestCase {
func testScan() {
@@ -33,7 +34,7 @@ class FavIconTests: XCTestCase {
performWebRequest(name: "scan") { requestCompleted in
do {
- try FavIcon.scan("https://apple.com") { icons, meta in
+ try FavIcon.scan("https://apple.com") { icons, _ in
actualIcons = icons
requestCompleted()
}
@@ -66,10 +67,8 @@ class FavIconTests: XCTestCase {
case .success(let image):
XCTAssertEqual(32, image.size.width)
XCTAssertEqual(32, image.size.height)
- break
case .failure(let error):
XCTFail("unexpected error returned for download: \(error)")
- break
}
}
@@ -314,4 +313,3 @@ private extension XCTestCase {
}
// swiftlint:enable function_body_length
-// swiftlint:enable line_length
« no previous file with comments | « FavIcon/Utils.swift ('k') | FavIconTests/HTMLDocumentTests.swift » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld