Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: README.md

Issue 29674584: Issue 5549 - Implement missing error handlings for custom filter lists (Closed)
Patch Set: removed filterError flag + added better way to check invalid filters Created Jan. 30, 2018, 1:11 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | background.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Shared Adblock Plus UI code 1 Shared Adblock Plus UI code
2 =========================== 2 ===========================
3 3
4 The user interface elements defined in this repository will be used by various 4 The user interface elements defined in this repository will be used by various
5 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be 5 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be
6 tested within this repository, even though they might not work exactly the same 6 tested within this repository, even though they might not work exactly the same
7 as they will do in the final product. 7 as they will do in the final product.
8 8
9 Directory structure 9 Directory structure
10 ------------------- 10 -------------------
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 This is the implementation of the Adblock Plus options page which is 90 This is the implementation of the Adblock Plus options page which is
91 the primary UI for changing settings and for managing filter lists. 91 the primary UI for changing settings and for managing filter lists.
92 92
93 To aid testing, the behavior of this page is affected by a number of URL 93 To aid testing, the behavior of this page is affected by a number of URL
94 parameters: 94 parameters:
95 95
96 * `addonVersion`: sets addon version application parameter that is used for 96 * `addonVersion`: sets addon version application parameter that is used for
97 creating the link to the version-specific release notes 97 creating the link to the version-specific release notes
98 * `addSubscription=true`: this parameter should trigger a dialog for adding 98 * `addSubscription=true`: this parameter should trigger a dialog for adding
99 subscriptions as initiated by clicking on an "abp:subscribe" link 99 subscriptions as initiated by clicking on an "abp:subscribe" link
100 * `filterError=true`: causes filter validation to fail, showing validation
101 errors when adding new filters on the options page
102 * `blockedURLs`: a comma-separated list of URLs that should be considered 100 * `blockedURLs`: a comma-separated list of URLs that should be considered
103 blocked (necessary to test the check for blocked scripts in sharing buttons). 101 blocked (necessary to test the check for blocked scripts in sharing buttons).
104 * `downloadStatus`: sets downloadStatus parameter for filter lists, can be used 102 * `downloadStatus`: sets downloadStatus parameter for filter lists, can be used
105 to trigger various filter list download errors 103 to trigger various filter list download errors
106 * `platform=chromium`: shows the opt-out for the developer tools panel 104 * `platform=chromium`: shows the opt-out for the developer tools panel
107 * `showNotificationUI=true`: simulates user having opted-out of notifications 105 * `showNotificationUI=true`: simulates user having opted-out of notifications
108 106
109 107
110 [crowdin]: https://crowdin.com 108 [crowdin]: https://crowdin.com
111 109
112 Linting 110 Linting
113 ------- 111 -------
114 112
115 You can lint the code using [ESLint](http://eslint.org). 113 You can lint the code using [ESLint](http://eslint.org).
116 114
117 eslint *.js lib ext 115 eslint *.js lib ext
118 116
119 You will need to set up ESLint and our configuration first, see 117 You will need to set up ESLint and our configuration first, see
120 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo) 118 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo)
121 for more information. 119 for more information.
OLDNEW
« no previous file with comments | « no previous file | background.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld