Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: skin/desktop-options.css

Issue 29674584: Issue 5549 - Implement missing error handlings for custom filter lists (Closed)
Patch Set: Created Jan. 19, 2018, 11:46 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « locale/en_US/desktop-options.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skin/desktop-options.css
===================================================================
--- a/skin/desktop-options.css
+++ b/skin/desktop-options.css
@@ -219,6 +219,7 @@
{
margin: 0.8rem 0rem;
display: flex;
+ align-self: center;
justify-content: flex-end;
}
@@ -1134,18 +1135,17 @@
#custom-filters[data-mode="empty"] #custom-filters-raw,
#custom-filters:not([data-mode="write"]) #custom-filters-raw-controls,
#custom-filters:not([data-mode="read"]) #custom-filters-edit,
+#custom-filters-edit-filters,
+#link-filters-on-edit-error,
.state span,
#acceptable-ads:not(.show-dnt-notification) #dnt
{
display: none;
}
-#all-filter-lists-table button[role="checkbox"][aria-checked="true"] + .state #state-active
-{
- display: inline;
-}
-
-#all-filter-lists-table button[role="checkbox"][aria-checked="false"] + .state #state-disabled
+#all-filter-lists-table button[role="checkbox"][aria-checked="true"] + .state #state-active,
+#all-filter-lists-table button[role="checkbox"][aria-checked="false"] + .state #state-disabled,
+#link-filters-on-edit-error.visible
{
display: inline;
}
@@ -1155,11 +1155,63 @@
margin-bottom: 0.8rem;
}
+#custom-filters-edit {
+ white-space: nowrap;
+}
+
+#custom-filters-edit-area {
+ display: flex;
+ width: 100%;
+}
+
+/*
+ avoid doubled margin glitchy behavior
+ as shown in visual specifications
+*/
+#custom-filters-edit-area .side-controls .side-controls {
+ margin: 0;
+}
+
+/*
+ visibility: hidden;
+ preserves the flex-box meaning,
+ keeping buttons on the right.
+*/
+#custom-filters-edit-error {
+ visibility: hidden;
+ display: flex;
+ align-self: center;
+ justify-content: flex-start;
+ font-weight: bold;
+}
+
+#custom-filters-edit-error.warning,
+#custom-filters-edit-filters
+{
+ color: #C11D26;
+ padding: 0.2rem 0.8rem;
+}
+
+#custom-filters-edit-error.warning {
+ visibility: visible;
+}
+
+#custom-filters-edit-filters {
+ display: block;
+ white-space: pre;
+ overflow: auto;
+}
+
+#custom-filters-edit-filters.many {
+ border: 1px solid silver;
+ max-height: 6.2rem;
+}
+
#custom-filters-raw
{
width: 100%;
height: 23.6rem;
- padding: 0.8rem;
+ padding: 0.8rem;
}
#custom-filters-raw:focus
@@ -1168,6 +1220,12 @@
border: 2px solid #077CA6;
}
+#custom-filters-raw.warning
+{
+ outline: none;
+ border: 2px solid #C11D26;
+}
+
#empty-custom-filters
{
padding: 1.5rem;
« no previous file with comments | « locale/en_US/desktop-options.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld