Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: desktop-options.html

Issue 29674584: Issue 5549 - Implement missing error handlings for custom filter lists (Closed)
Patch Set: removed filterError flag + added better way to check invalid filters Created Jan. 30, 2018, 1:11 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « background.js ('k') | desktop-options.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: desktop-options.html
===================================================================
--- a/desktop-options.html
+++ b/desktop-options.html
@@ -289,6 +289,9 @@
<header>
<h2 class="i18n_options_customFilters_title"></h2>
<p class="i18n_options_customFilters_description"></p>
+ <p>
+ <a class="i18n_options_customFilters_learn" id="link-filters-1" target="_blank"></a>
+ </p>
</header>
<div id="custom-filters">
<h3 class="i18n_options_customFilters_widget_title"></h3>
@@ -297,18 +300,22 @@
<button class="i18n_options_customFilters_start primary" data-action="edit-custom-filters">
</button>
<p>
- <a class="i18n_options_customFilters_learn" id="link-filters" target="_blank"></a>
+ <a class="i18n_options_customFilters_learn" id="link-filters-2" target="_blank"></a>
</p>
</div>
<textarea id="custom-filters-raw" rows="15"></textarea>
- <div class="side-controls">
- <button id="custom-filters-edit" class="i18n_options_customFilter_edit secondary" data-action="edit-custom-filters">
- </button>
- <div class="side-controls" id="custom-filters-raw-controls">
- <button class="i18n_options_customFilter_cancel secondary" data-action="cancel-custom-filters"></button>
- <button class="i18n_options_customFilter_save primary" data-action="save-custom-filters"></button>
+ <div id="custom-filters-edit-area">
+ <div id="custom-filters-edit-error" class="i18n_options_customFilters_edit_error"></div>
+ <div class="side-controls">
+ <button id="custom-filters-edit" class="i18n_options_customFilter_edit secondary" data-action="edit-custom-filters">
+ </button>
+ <div id="custom-filters-raw-controls" class="side-controls">
+ <button class="i18n_options_customFilter_cancel secondary" data-action="cancel-custom-filters"></button>
+ <button class="i18n_options_customFilter_save primary" data-action="save-custom-filters"></button>
+ </div>
</div>
</div>
+ <ul id="custom-filters-error"></ul>
</div>
</section>
</div>
« no previous file with comments | « background.js ('k') | desktop-options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld