Unified Diff: messageResponder.js
Issue 29674584:
Issue 5549 - Implement missing error handlings for custom filter lists (Closed)
Patch Set: removed filterError flag + added better way to check invalid filters
Created Jan. 30, 2018, 1:11 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« locale/en_US/desktop-options.json ('k')
|
skin/desktop-options.css » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: messageResponder.js |
| =================================================================== |
| --- a/messageResponder.js |
| +++ b/messageResponder.js |
| @@ -269,7 +269,15 @@ |
| for (let error of result.errors) |
| { |
| if (error.type != "unexpected-filter-list-header") |
| - errors.push(error.toString()); |
| + { |
| + // passing along all the info available through the error object |
| + // in case we'll ever need these extra info in the future |
| + errors.push({ |
| + lineno: error.lineno, |
| + reason: error.reason, |
| + type: error.type |
| + }); |
| + } |
| } |
| if (errors.length > 0) |
« no previous file with comments
|
« locale/en_US/desktop-options.json ('k')
|
skin/desktop-options.css » ('j')
|
no next file with comments »
