Issue 5542: Implement tooltips for new options page

desktop-options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 1277 matching lines @@
         setPrivacyConflict();
         break;
       case "downloading":
       case "downloadStatus":
       case "homepage":
       case "lastDownload":
       case "title":
         updateSubscription(subscription);
         break;
       case "added":
-        let {url, recommended} = subscription;
+        let {url} = subscription;
         // Handle custom subscription
         if (/^~user/.test(url))
         {
           loadCustomFilters(subscription.filters);
           return;
         }
         else if (url in subscriptionsMap)
           updateSubscription(subscription);
         else
           addSubscription(subscription);
@@ skipping 85 matching lines @@
 
     let checkbox = document.querySelector(
       "[data-pref='" + key + "'] button[role='checkbox']"
     );
     if (checkbox)
       checkbox.setAttribute("aria-checked", value);
   }
 
   function updateTooltips()
   {
-    let anchors = document.querySelectorAll(":not(.tooltip) > [data-tooltip]");
-    for (let anchor of anchors)
+    const anchors = document.querySelectorAll("[data-tooltip]");

[sergei, 2018/02/19 10:18:42]

I thought we don't use `const` in such cases, do we?

[a.giammarchi, 2018/02/19 10:26:38]

why not, if I might ask? `const` is used to guard against undesired
reassignments. It's true that in this file I actually should drop all `let` and
use `const` instead, but for new code, where it makes sense, I don't see why we
shouldn't use language guards/features.

If this was explicitly written in some code guideline thought, I'd be happy to
stick with it and preserve consistency. Yet I don't understand why would we make
such decision.

Thanks in advance for any sort of clarification.

[sergei, 2018/02/19 10:44:45]

Yep, I know what it is for but I got several times in codereviwes that we should
use `let` in such cases. That's because I'm asking to know the current state.
I find the wording actually vague
https://adblockplus.org/en/coding-style#javascript
"> Use const for constant expressions that could as well have been inlined (e.g.
static parameters, imported modules, etc.)."

[a.giammarchi, 2018/02/19 10:53:05]

that's the second point though, the first one says:
The for/of is block-scoping so I think I've followed the rules.

+    for (const anchor of anchors)
     {
       let id = anchor.getAttribute("data-tooltip");
 
-      let wrapper = document.createElement("div");
-      wrapper.setAttribute("aria-describedby", id);
-      wrapper.setAttribute("tabindex", "0");
-      wrapper.className = "icon tooltip";
-      anchor.parentNode.replaceChild(wrapper, anchor);
-      wrapper.appendChild(anchor);
+      // instead of replacing the whole node
+      // just make it non discoverable for
+      // the next updateTooltips call
+      anchor.removeAttribute("data-tooltip");
+      anchor.classList.add("icon", "tooltip");
 
-      let tooltip = document.createElement("div");
+      const tooltip = document.createElement("div");
+      tooltip.setAttribute("role", "tooltip");
+      // needed by aria-describedby
       tooltip.id = id;
-      tooltip.setAttribute("role", "tooltip");
 
-      let paragraph = document.createElement("p");
+      const paragraph = document.createElement("p");
       paragraph.textContent = getMessage(id);
       tooltip.appendChild(paragraph);
 
-      wrapper.appendChild(tooltip);
+      anchor.appendChild(tooltip);
+      anchor.setAttribute("aria-describedby", id);
+
+      // if focused and the mouse reaches another (?)
+      // blur the active element to drop previous tooltip
+      anchor.addEventListener("mouseover", dropActiveElement);
     }
   }
 
+  function dropActiveElement(event)
+  {
+    const active = event.target.ownerDocument.activeElement;
+    if (active)
+      active.blur();
+  }
+
   ext.onMessage.addListener((message) =>
   {
     switch (message.type)
     {
       case "app.respond":
         switch (message.action)
         {
           case "addSubscription":
             let subscription = message.args[0];
             let dialog = E("dialog-content-predefined");
@@ skipping 34 matching lines @@
   });
   browser.runtime.sendMessage({
     type: "subscriptions.listen",
     filter: ["added", "disabled", "homepage", "lastDownload", "removed",
              "title", "downloadStatus", "downloading"]
   });
 
   window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
   window.addEventListener("hashchange", onHashChange, false);
 }