Delta Between Two Patch Sets: desktop-options.html
Issue 29683678:
Issue 5542: Implement tooltips for new options page (Closed)
Left Patch Set:
Created Jan. 29, 2018, 4:21 p.m.
Right Patch Set: cleaning up the patch
Created Feb. 5, 2018, 12:35 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
desktop-options.js » ('j')
|
desktop-options.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| (no file at all) | |
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 - This file is part of Adblock Plus <https://adblockplus.org/>, | 3 - This file is part of Adblock Plus <https://adblockplus.org/>, |
| 4 - Copyright (C) 2006-present eyeo GmbH | 4 - Copyright (C) 2006-present eyeo GmbH |
| 5 - | 5 - |
| 6 - Adblock Plus is free software: you can redistribute it and/or modify | 6 - Adblock Plus is free software: you can redistribute it and/or modify |
| 7 - it under the terms of the GNU General Public License version 3 as | 7 - it under the terms of the GNU General Public License version 3 as |
| 8 - published by the Free Software Foundation. | 8 - published by the Free Software Foundation. |
| 9 - | 9 - |
| 10 - Adblock Plus is distributed in the hope that it will be useful, | 10 - Adblock Plus is distributed in the hope that it will be useful, |
| (...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 80 <header> | 80 <header> |
| 81 <h1 class="i18n_options_tab_general"></h1> | 81 <h1 class="i18n_options_tab_general"></h1> |
| 82 <p class="i18n_options_general_description"></p> | 82 <p class="i18n_options_general_description"></p> |
| 83 </header> | 83 </header> |
| 84 <section class="cols"> | 84 <section class="cols"> |
| 85 <h2 class="i18n_options_privacy_header"></h2> | 85 <h2 class="i18n_options_privacy_header"></h2> |
| 86 <ul class="list" id="recommend-protection-list-table"> | 86 <ul class="list" id="recommend-protection-list-table"> |
| 87 <template> | 87 <template> |
| 88 <button data-action="toggle-remove-subscription" role="checkbox" c lass="control icon"></button> | 88 <button data-action="toggle-remove-subscription" role="checkbox" c lass="control icon"></button> |
| 89 <span data-display="title"></span> | 89 <span data-display="title"></span> |
| 90 <span data-tooltip="options_protection_%value%_tooltip"></span> | 90 <button data-tooltip="options_protection_%value%_tooltip"></button > |
| 91 </template> | 91 </template> |
| 92 </ul> | 92 </ul> |
| 93 </section> | 93 </section> |
| 94 <section class="cols"> | 94 <section class="cols"> |
| 95 <header> | 95 <header> |
| 96 <h2 class="i18n_options_acceptableAds_header"></h2> | 96 <h2 class="i18n_options_acceptableAds_header"></h2> |
| 97 <p class="i18n_options_acceptableAds_description"></p> | 97 <p class="i18n_options_acceptableAds_description"></p> |
| 98 </header> | 98 </header> |
| 99 <form id="acceptable-ads"> | 99 <form id="acceptable-ads"> |
| 100 <div id="tracking-warning"> | 100 <div id="tracking-warning"> |
| (...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 198 <header> | 198 <header> |
| 199 <h1 class="i18n_options_tab_advanced"></h1> | 199 <h1 class="i18n_options_tab_advanced"></h1> |
| 200 <p class="i18n_options_advanced_description"></p> | 200 <p class="i18n_options_advanced_description"></p> |
| 201 </header> | 201 </header> |
| 202 <section class="cols"> | 202 <section class="cols"> |
| 203 <h2 class="i18n_options_customize_header"></h2> | 203 <h2 class="i18n_options_customize_header"></h2> |
| 204 <ul id="customize" class="list"> | 204 <ul id="customize" class="list"> |
| 205 <li data-pref="shouldShowBlockElementMenu"> | 205 <li data-pref="shouldShowBlockElementMenu"> |
| 206 <button class="icon" role="checkbox" data-action="toggle-pref"></b utton> | 206 <button class="icon" role="checkbox" data-action="toggle-pref"></b utton> |
| 207 <span class="i18n_options_customize_blockElement" data-display="ti tle"></span> | 207 <span class="i18n_options_customize_blockElement" data-display="ti tle"></span> |
| 208 <span data-tooltip="options_customize_blockElement_tooltip"></span > | 208 <button data-tooltip="options_customize_blockElement_tooltip"></bu tton> |
| 209 </li> | 209 </li> |
| 210 <li data-pref="show_devtools_panel"> | 210 <li data-pref="show_devtools_panel"> |
| 211 <button class="icon" role="checkbox" data-action="toggle-pref"></b utton> | 211 <button class="icon" role="checkbox" data-action="toggle-pref"></b utton> |
| 212 <span class="i18n_options_customize_showDevToolsPanel" data-displa y="title"></span> | 212 <span class="i18n_options_customize_showDevToolsPanel" data-displa y="title"></span> |
| 213 <span data-tooltip="options_customize_showDevToolsPanel_tooltip">< /span> | 213 <button data-tooltip="options_customize_showDevToolsPanel_tooltip" ></button> |
| 214 </li> | 214 </li> |
| 215 <li data-pref="notifications_ignoredcategories"> | 215 <li data-pref="notifications_ignoredcategories"> |
| 216 <button class="icon" role="checkbox" data-action="toggle-pref"></b utton> | 216 <button class="icon" role="checkbox" data-action="toggle-pref"></b utton> |
| 217 <span class="i18n_options_customize_showNotifications" data-displa y="title"></span> | 217 <span class="i18n_options_customize_showNotifications" data-displa y="title"></span> |
| 218 <span data-tooltip="options_customize_showNotifications_tooltip">< /span> | 218 <button data-tooltip="options_customize_showNotifications_tooltip" ></button> |
| 219 </li> | 219 </li> |
| 220 </ul> | 220 </ul> |
| 221 </section> | 221 </section> |
| 222 | 222 |
| 223 <section> | 223 <section> |
| 224 <header> | 224 <header> |
| 225 <h2 class="i18n_options_filterList_title"></h2> | 225 <h2 class="i18n_options_filterList_title"></h2> |
| 226 <p> | 226 <p> |
| 227 <span class="i18n_options_filterList_description"></span> | 227 <span class="i18n_options_filterList_description"></span> |
| 228 <a id="filter-lists-learn-more" class="i18n_options_learn_more" ta rget="_blank"></a> | 228 <a id="filter-lists-learn-more" class="i18n_options_learn_more" ta rget="_blank"></a> |
| (...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 429 </div> | 429 </div> |
| 430 <!-- Notification --> | 430 <!-- Notification --> |
| 431 <div id="notification" aria-hidden="true" aria-live="polite"> | 431 <div id="notification" aria-hidden="true" aria-live="polite"> |
| 432 <strong id="notification-text"></strong> | 432 <strong id="notification-text"></strong> |
| 433 <button class="icon close secondary" data-action="hide-notification"> | 433 <button class="icon close secondary" data-action="hide-notification"> |
| 434 <span class="i18n_options_notification_hide sr-only"></span> | 434 <span class="i18n_options_notification_hide sr-only"></span> |
| 435 </button> | 435 </button> |
| 436 </div> | 436 </div> |
| 437 </body> | 437 </body> |
| 438 </html> | 438 </html> |
| LEFT | RIGHT |
« no previous file
|
desktop-options.js » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
