Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: includes/navbar.tmpl

Issue 29689571: Fixes #4 - Update primary and footer navigation contents (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Patch Set: Created Feb. 5, 2018, 9:43 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « includes/footer.tmpl ('k') | locales/en/menu.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {% from "macros/pageitem" import pageitem %} 1 {% from "macros/pageitem" import pageitem %}
2 2
3 <nav id="navbar"> 3 <nav id="navbar">
4 <div class="container"> 4 <div class="container">
5 {{ "index" | linkify(id="navbar-logo") }} 5 {{ "index" | linkify(id="navbar-logo") }}
6 <img 6 <img
7 src="/img/navbar-logo.png" 7 src="/img/navbar-logo.png"
8 srcset="/img/navbar-logo.svg 2x"> 8 srcset="/img/navbar-logo.svg 2x">
9 <span>{{ "Adblock <strong>Plus</strong>" | translate("navbar-logo-text", " Navbar logo text") }}</span> 9 <span>{{ "Adblock <strong>Plus</strong>" | translate("navbar-logo-text", " Navbar logo text") }}</span>
10 </a> 10 </a>
11 <a href="#" id="navbar-menu-toggle"> 11 <a href="#" id="navbar-menu-toggle">
12 <img 12 <img
13 src="/img/menu-toggle.png" 13 src="/img/menu-toggle.png"
14 srcset="/img/menu-toggle.svg 2x"> 14 srcset="/img/menu-toggle.svg 2x">
15 </a> 15 </a>
16 <ul id="navbar-menu"> 16 <ul id="navbar-menu">
17 {% for pagename in ["about", "features", "bugs", "contribute"] %} 17 {% for pagename in ["about", "contribute"] %}
saroyanm 2018/02/05 15:44:10 In the Issue it says: "Features are getting merged
saroyanm 2018/02/05 15:44:10 What was the reason of making the Issue reporting
ire 2018/02/05 16:15:01 Yes, this change will not be pushed to master unti
ire 2018/02/05 16:15:02 Yes it's been through the QA team. I don't know sp
18 <li> 18 <li>
19 {{ pagename | linkify }}{{ get_string(pagename, "menu") }}</a> 19 {{ pagename | linkify }}{{ get_string(pagename, "menu") }}</a>
20 </li> 20 </li>
21 {% endfor %} 21 {% endfor %}
22 <li>
23 {{ "documentation" | linkify }}{{ get_string("help", "menu") }}</a>
24 </li>
22 <li id="navbar-locale-menubar"> 25 <li id="navbar-locale-menubar">
23 <a href="#" id="navbar-locale-selected"> 26 <a href="#" id="navbar-locale-selected">
24 {{ config.get("langnames", locale) }} ({{ locale | to_og_locale | to_o g_location }}) 27 {{ config.get("langnames", locale) }} ({{ locale | to_og_locale | to_o g_location }})
25 </a> 28 </a>
26 <ul id="navbar-locale-menu"> 29 <ul id="navbar-locale-menu">
27 {% for available_locale in available_locales %} 30 {% for available_locale in available_locales %}
28 <li> 31 <li>
29 {{ page | linkify(available_locale) }} 32 {{ page | linkify(available_locale) }}
30 {{ config.get("langnames", available_locale) }} ({{ available_lo cale | to_og_locale | to_og_location }}) 33 {{ config.get("langnames", available_locale) }} ({{ available_lo cale | to_og_locale | to_og_location }})
31 </a> 34 </a>
32 </li> 35 </li>
33 {% endfor %} 36 {% endfor %}
34 </ul>{# #navbar-locale-menu #} 37 </ul>{# #navbar-locale-menu #}
35 </li> 38 </li>
36 </ul>{# #navbar-menu #} 39 </ul>{# #navbar-menu #}
37 </div>{# .container #} 40 </div>{# .container #}
38 </nav>{# #navbar #} 41 </nav>{# #navbar #}
OLDNEW
« no previous file with comments | « includes/footer.tmpl ('k') | locales/en/menu.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld