Noissue - Add crowdin api config support

tests/test_translations.py

 import os
 import shutil
 import pytest
-import zipfile
 
 from wsgi_intercept import urllib3_intercept
 from wsgi_intercept import add_wsgi_intercept
 from wsgi_intercept import remove_wsgi_intercept
 
-from crowdin_mock_api import CrowdinMock
+import crowdin_mock_api
 from cms.bin import translate
 
 
 @pytest.fixture(scope='module')
 def expect_requests():
     return [
         ('info?key=test_key&json=1', ''),
         ('supported-languages?key=test_key&json=1', ''),
         ('add-file?key=test_key&json=1', '.json'),
         ('upload-translation?key=test_key&json=1', 'simple'),
         ('delete-file?key=test_key&json=1', '.json'),
         ('delete-file?key=test_key&json=1', '.json'),
         ('delete-file?key=test_key&json=1', '.json'),
         ('delete-file?key=test_key&json=1', '.json'),
         ('delete-directory?key=test_key&json=1', ''),
         ('delete-directory?key=test_key&json=1', ''),
         ('export?key=test_key&json=1', ''),
         ('download/all.zip?key=test_key', ''),
     ]
 
 
-@pytest.fixture(scope='module')
-def api_zip(temp_site, request):
-    zip_name = 'all'
+@pytest.fixture
+def api_zip(tmpdir, temp_site, request):
     input_dir = os.path.join(temp_site, 'locales')
-    shutil.make_archive(zip_name, 'zip', input_dir)
-    yield zipfile.ZipFile(zip_name + '.zip')

[Vasily Kuznetsov, 2018/03/05 17:21:33]

It seems like this zipfile object is not used anywhere. Maybe we just return the
path?

[Jon Sonesen, 2018/03/06 02:30:19]

Acknowledged.

-    os.remove(zip_name + '.zip')

[Vasily Kuznetsov, 2018/03/05 17:21:33]

You could put this file into a temporary directory and then you would't need to
remove it yourself. It's about the same amount of code (this fixture is
module-wide, so you can't simply use `tmpdir` and will have to use
`tmpdir_factory` instead) but seems a bit cleaner...

[Jon Sonesen, 2018/03/06 02:30:18]

Acknowledged.

+    shutil.make_archive(tmpdir.join('all').strpath, 'zip', input_dir)
+    return tmpdir.strpath
 
 
-@pytest.fixture(scope='session')
-def mock_api(temp_site):

[Vasily Kuznetsov, 2018/03/05 17:21:33]

The `CrowdinMock` has a hidden dependency from the zip file that `api_zip`
fixture creates. It would be better to make it explicit by making this fixture
depend on `api_zip` (that will return the path to the zip file) and then pass
its value into `CrowdinMock`.

[Jon Sonesen, 2018/03/06 02:30:19]

Acknowledged.

-    api = CrowdinMock(os.path.join(temp_site, 'locales'))
-    api.run()
+@pytest.fixture
+def mock_api(temp_site, api_zip):
+    app = crowdin_mock_api.load(os.path.join(temp_site, 'locales'), api_zip)
     host = 'api.crowdin.com'
     port = 443
     urllib3_intercept.install()
-    add_wsgi_intercept(host, port, lambda: api.app.wsgi_app)
-    yield api
+    add_wsgi_intercept(host, port, lambda: app.wsgi_app)
+    yield app
     remove_wsgi_intercept()
 
 
-def test_sync(temp_site, mock_api, api_zip, expect_requests):
+def test_sync(temp_site, mock_api, expect_requests):
     translate.crowdin_sync(temp_site, 'test_key')
-    for (url, data), (expect_url, expect_data) in zip(mock_api.app.request_log,
+    for (url, data), (expect_url, expect_data) in zip(mock_api.request_log,
                                                       expect_requests):
         assert expect_url in url
         assert expect_data in data