Noissue - Remove Redundant Parentheses

cms/converters.py

 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-present eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 163 matching lines @@
         if callback:
             callback(page, locale, name, result, comment, fixed_strings)
 
         # Insert fixed strings
         for i, fixed_string in enumerate(fixed_strings, 1):
             result = result.replace('{{{}}}'.format(i), fixed_string)
 
         # Insert attributes
         result = escape(result)
 
-        def stringify_attribute(attribute):

[Jon Sonesen, 2018/03/01 00:00:15]

alternatively, you can expand tuples when passed eg
stringify_attribute(*attribute) then in the definition you can use positional
argument definitions, def stringify_attribute(name, value) then call as above

-            name, value = attribute
+        def stringify_attribute(name, value):
             return '{}="{}"'.format(
                 escape(name),
                 escape(self.insert_localized_strings(value, {}))
             )
 
         for tag in self.whitelist:
             allowed_contents = '(?:[^<>]|{})'.format('|'.join(
                 '<(?:{}[^<>]*?|/{})>'.format(t, t)
                 for t in map(re.escape, self.whitelist - {tag})
             ))
             saved = saved_attributes.get(tag, [])
             for attrs in saved:
-                attrs = map(stringify_attribute, attrs)
+                attrs = [stringify_attribute(*attr) for attr in attrs]
                 result = re.sub(
                     r'{}({}*?){}'.format(re_escape('<{}>'.format(tag)),
                                          allowed_contents,
                                          re_escape('</{}>'.format(tag))),
                     lambda match: r'<{}{}>{}</{}>'.format(
                         tag,
                         ' ' + ' '.join(attrs) if attrs else '',
                         match.group(1),
                         tag
                     ),
@@ skipping 320 matching lines @@
             stack[-1]['subitems'].append(item)
             stack.append(item)
         return structured
 
 
 converters = {
     'html': RawConverter,
     'md': MarkdownConverter,
     'tmpl': TemplateConverter,
 }