docs/content/includes.md - Issue 29711686: Noissue - Update docs to describe include files metadata override

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: docs/content/includes.md

Issue 29711686: Noissue - Update docs to describe include files metadata override (Closed) Base URL: https://hg.adblockplus.org/cms

Left Patch Set: Created March 1, 2018, 1:52 a.m.

Right Patch Set: actually address P1 comment Created March 2, 2018, 6:08 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 # Include files #	1 # Include files #

2	2

3 The following tag inserts an include file into the page (can be in a different	3 The following tag inserts an include file into the page (can be in a different

4 format):	4 format):

5	5

6 <? include foo ?>	6 <? include foo ?>

7	7

8 Include files should be placed into the `includes` directory of the repository.	8 Include files should be placed into the `includes` directory of the repository.

9 In the case above the contents of `includes/foo.md` or `includes/foo.tmpl` will	9 In the case above the contents of `includes/foo.md` or `includes/foo.tmpl` will

10 be inserted (whichever is present).	10 be inserted (whichever is present).

11	11

12 Also, page front matter (metadata defined at the top of the file) will	12 Also, the metadata variables from the include file are merged with the page meta data
Vasily Kuznetsov 2018/03/01 15:41:21 Maybe better to formulate this as something like " Maybe better to formulate this as something like "the metadata variables from the include file will be added to the page metadata (with the metadata variables from the include having priority)"? What do you think? Jon Sonesen 2018/03/02 00:58:01 Yeah thats much better, thanks. This means that an Show quoted text On 2018/03/01 15:41:21, Vasily Kuznetsov wrote: > Maybe better to formulate this as something like "the metadata variables from > the include file will be added to the page metadata (with the metadata variables > from the include having priority)"? What do you think? Yeah thats much better, thanks. This means that an include can change the template of a page correct? if so perhaps this should also be pointed out. Jon Sonesen 2018/03/02 01:10:14 basically add to yours, "this means that a include Show quoted text On 2018/03/01 15:41:21, Vasily Kuznetsov wrote: > Maybe better to formulate this as something like "the metadata variables from > the include file will be added to the page metadata (with the metadata variables > from the include having priority)"? What do you think? basically add to yours, "this means that a include file is capable of things like overriding a page's default template."?
13 be overridden by the included file.	13 (with the include file's metadata having priority). This means that a include fi le

	14 is capable of things like overriding a page's default template, or title.

LEFT	RIGHT