.travis/travis-script.sh - Issue 29714583: Issue 6220 - include running of native tests on travis-ci for emscripten

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: .travis/travis-script.sh

Issue 29714583: Issue 6220 - include running of native tests on travis-ci for emscripten (Closed) Base URL: github.com:adblockplus/adblockpluscore

Patch Set: Created March 5, 2018, 3:23 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 #!/usr/bin/env bash	1 #!/usr/bin/env bash

2	2

3 . .travis/activate-nodejs.sh	3 . .travis/activate-nodejs.sh

4	4

5 set -x	5 set -x

6 set -e	6 set -e

7	7

8 PATH=${PATH}:${TRAVIS_BUILD_DIR}/third_party/ninja:$(python3 -c "import sysconfi g;print(sysconfig.get_paths('posix_user')['scripts'])")	8 PATH=${PATH}:${TRAVIS_BUILD_DIR}/third_party/ninja:$(python3 -c "import sysconfi g;print(sysconfig.get_paths('posix_user')['scripts'])")

9	9

10 meson --buildtype ${BUILDTYPE} build	10 meson --buildtype ${BUILDTYPE} build/js

11 ninja -C build	11 ninja -C build/js

12 npm test	12 npm test

	13

	14 USE_ASAN=true

	15 if [[ "${BUILDTYPE}" == "release" ]]; then

	16 USE_ASAN=false

	17 fi

	18 meson -Dnative=true -Dasan=${USE_ASAN} --buildtype ${BUILDTYPE} build/native

	19 ninja -C build/native

	20 ./build/native/abptest
	hub 2018/03/05 15:35:24 `ninja -C build/native test` is enough to build an `ninja -C build/native test` is enough to build and run the test. I propose that lines 19-20 should be replaced by this. sergei 2018/03/05 15:58:16 This is a cool feature but it hides the output of Show quoted text On 2018/03/05 15:35:24, hub wrote: > `ninja -C build/native test` is enough to build and run the test. I propose that > lines 19-20 should be replaced by this. This is a cool feature but it hides the output of the tests if there are no failed tests. I feel more comfortable when I can open the log and see something green like [==========] 15 tests from 7 test cases ran. (6 ms total) [ PASSED ] 15 tests. and ensure that there is no any additional output. The latter is useful because it helps to get rid of overlooked debug prints when one runs CI before sending the code for codereview .
OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »