Issue 6440 - Use long-lived connections to listen to extension events

js/desktop-options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 1401 matching lines @@
     tooltip.setAttribute("role", "tooltip");
 
     let paragraph = document.createElement("p");
     paragraph.textContent = getMessage(id);
     tooltip.appendChild(paragraph);
 
     wrapper.appendChild(tooltip);
   }
 }
 
-ext.onMessage.addListener((message) =>
+let port = browser.runtime.connect({name: "ui"});
+
+port.onMessage.addListener((message) =>
 {
   switch (message.type)
   {
     case "app.respond":
       switch (message.action)
       {
         case "addSubscription":
           let subscription = message.args[0];
           let dialog = E("dialog-content-predefined");
           dialog.querySelector("h3").textContent = subscription.title || "";
@@ skipping 10 matching lines @@
       break;
     case "prefs.respond":
       onPrefMessage(message.action, message.args[0], false);
       break;
     case "subscriptions.respond":
       onSubscriptionMessage(message.action, message.args[0]);
       break;
   }
 });
 
-browser.runtime.sendMessage({
+port.postMessage({
   type: "app.listen",
   filter: ["addSubscription", "focusSection"]
 });
-browser.runtime.sendMessage({
+port.postMessage({
   type: "filters.listen",
   filter: ["added", "loaded", "removed"]
 });
-browser.runtime.sendMessage({
+port.postMessage({
   type: "prefs.listen",
   filter: ["notifications_ignoredcategories", "notifications_showui",
            "show_devtools_panel", "shouldShowBlockElementMenu",
            "ui_warn_tracking"]
 });
-browser.runtime.sendMessage({
+port.postMessage({
   type: "subscriptions.listen",
   filter: ["added", "disabled", "homepage", "lastDownload", "removed",
            "title", "downloadStatus", "downloading"]
 });
 
 window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 window.addEventListener("hashchange", onHashChange, false);